Closed
Bug 520709
Opened 15 years ago
Closed 15 years ago
mochitest to ensure name/description are updated on a11y focus if they were changed on DOM focus
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file)
17.41 KB,
patch
|
MarcoZ
:
review+
|
Details | Diff | Splinter Review |
We need mochitest for the following case. When aria-describedby is changed on DOM focus then accessible description should be up to dated when a11y focus is fired.
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #404762 -
Flags: review?(marco.zehe)
Comment 2•15 years ago
|
||
Comment on attachment 404762 [details] [diff] [review]
patch
A few nits:
>+ this.getID = function synthFocus_getID() { return aNodeOrID + " click"; }
As per our chat on IRC, we should add a call to getPrettyName so that when someone send a DOM node in instead of an ID, we still output a message that makes sense.
>+ // The aria-describedby is chnaged on DOM focus. Accessible description
"... is changed ..." (typo).
>+ // should be up to dated when a11y focus is fired.
"... should be updated..."
>+ <input id="textbox">
Please end this with />. I hate these old-style tags that are opened but never closed. :)
Attachment #404762 -
Flags: review?(marco.zehe) → review+
Assignee | ||
Comment 3•15 years ago
|
||
(In reply to comment #2)
> Please end this with />. I hate these old-style tags that are opened but never
> closed. :)
It's HTML and it doesn't like to close single tags iirc. We use this everywhere in tests.
Assignee | ||
Comment 4•15 years ago
|
||
landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/05e5b1a4eb28
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•