Closed Bug 520857 Opened 11 years ago Closed 11 years ago

Enable extra-jar.mn for SeaMonkey locales

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0

People

(Reporter: fredchat, Assigned: adriank)

Details

(Keywords: fixed-seamonkey2.0)

Attachments

(1 file)

Actually, extra-jar.mn doesn't seem to be enabled which doesn't allow us to add extra files.

Example : http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/fr/file/4f4d1b039a74/suite/extra-jar.mn

extra file mail_help_newsblogs_help.xhtml isn't in the last nightlies.
I hope I can look into this before the next RC, but I current can't guarantee it, there's quite a long list of work I have to do and this weekend including Monday will mostly be real life (RC2 should be built next week).

If some else, like Adrian, could look into that in the mean time, it would be very much appreciated.
oops, using the IRC nick triggered the wrong Adrian K. :P
I'd really like to help here, but unfortunately I have no idea of how the build system works, so no idea how to fix this.
Robert: the only reference to 'extra-jar.mn' I could find was in calendars code:
http://mxr.mozilla.org/comm-central/source/calendar/sunbird/locales/jar.mn#17

It looks like we should add at the end of this file:
http://mxr.mozilla.org/comm-central/source/suite/locales/jar.mn#348
the following lines:

# Extra l10n files for documentation and such
#includesubst @LOCALE_SRCDIR@/extra-jar.mn


Now the question is, if that alone will make it work...
Flags: wanted-seamonkey2.0?
Version: unspecified → Trunk
Attached patch Adrian's patchSplinter Review
Here's Adrian's proposal in actual patch form. I tested it and it works, but will break fr right now as the files weren't actually added to the repository.

Still, as the patch works and I tested it and it looks good but was Adrian's work and not actually mine, I can review and approve it. I'll also do the checkin in a moment.
Attachment #406019 - Flags: review+
Attachment #406019 - Flags: approval-seamonkey2.0+
Pushed as http://hg.mozilla.org/comm-central/rev/e0cac80b9bc0

Adrian, thanks for finding this!
Assignee: nobody → akalla
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: wanted-seamonkey2.0?
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.