Closed
Bug 520914
Opened 15 years ago
Closed 9 years ago
nsCookieService::SetCookieString() doesn't use aPrompt argument
Categories
(Core :: Networking: Cookies, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: WeirdAl, Assigned: wesongathedeveloper)
References
()
Details
(Whiteboard: [wontfix?])
Attachments
(1 file)
|
25.10 KB,
patch
|
dwitte
:
review+
|
Details | Diff | Splinter Review |
I'd suggest either do something with aPrompt, or remove the argument from the IDL, service and callers.
goodfirstbug?
|
||
Comment 2•14 years ago
|
||
Comment on attachment 481759 [details] [diff] [review]
Remove Redundancy
Looks good, r=dwitte. We'll want to land this after we branch for Firefox 4, and we'll also want to tidy up some other stuff in the interface -- remove aFirstURI, use ACString instead of string, consolidate nsICookieService/nsICookieManager/nsICookieManager2, etc.
Attachment #481759 -
Flags: feedback?(cbiesinger) → review+
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #2)
> and we'll also want to tidy up some other stuff in the interface -- remove
> aFirstURI, use ACString instead of string, consolidate
> nsICookieService/nsICookieManager/nsICookieManager2, etc.
Perhaps we should file some other bugs for those tasks
Assignee: nobody → wesongathedeveloper
|
||
Comment 4•11 years ago
|
||
Note that we can't really take this patch because it will break a lot of add-ons. I have filed bug 943414 to warn if somebody passes a non-null argument to aPrompt.
Whiteboard: [wontfix?]
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•