520996 - iconic .menu-right definition should match for normal menus

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[[e-mail]]

Apart from the intentional extra icon and class name changes, there is also an extra pack="center" attribute on the .menu-right element. Winstripe and GNOMEstripe don't care because they set -moz-appearance but themes such as Modern  and PMStripe (and possibly Pinstripe, although obviously there only iconic menus in context popups are affected) that set a list-style-image have to use padding to force the child image to the left edge of the box.

Comment 1

[[e-mail]]

Attachment: Copy from the normal menu binding

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 405048 [details] [diff] [review]
Copy from the normal menu binding

Pinstripe just makes the box as wide as the image and uses margin to position the box. Not sure why you do it differently.

Comment 3

[[e-mail]]

Pushed changeset 7fd7c858418d to mozilla-central.

Comment 4

[[e-mail]]

Comment on attachment 405048 [details] [diff] [review]
Copy from the normal menu binding

Makes things minusculely saner.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 405048 [details] [diff] [review]
Copy from the normal menu binding

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.