Closed
Bug 52104
Opened 24 years ago
Closed 21 years ago
about:logo is missing
Categories
(Core :: Networking, defect, P3)
Core
Networking
Tracking
()
VERIFIED
FIXED
Future
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file, 2 obsolete files)
705 bytes,
patch
|
caillon
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
about:logo should be hooked up to "chrome://global/content/logo.gif"
Assignee | ||
Comment 1•24 years ago
|
||
Is this a single line fix or do we need a new protocol handler/method?
Comment 3•22 years ago
|
||
Why do we need that? I don't think we do.
-> browser-general - this is not networking.
Component: Networking → Browser-General
Comment 6•22 years ago
|
||
about:logo is shorter than chrome://global/content/logo.gif :)
Assignee | ||
Comment 7•22 years ago
|
||
isn't it just to add about:logo here http://lxr.mozilla.org/mozilla/source/netwerk/protocol/about/src/nsAboutRedirector.cpp#68 and here: http://lxr.mozilla.org/mozilla/source/netwerk/build/nsNetModule.cpp#851 ?
Assignee | ||
Comment 8•22 years ago
|
||
Assignee | ||
Comment 9•22 years ago
|
||
Attachment #109029 -
Attachment is obsolete: true
Assignee | ||
Updated•22 years ago
|
Attachment #109031 -
Flags: review?(timeless)
Attachment #109031 -
Flags: superreview?(darin)
Attachment #109031 -
Flags: review?(timeless)
Attachment #109031 -
Flags: review+
Comment 11•22 years ago
|
||
Comment on attachment 109031 [details] [diff] [review] still not sure if this is all...:) sr=darin
Attachment #109031 -
Flags: superreview?(darin) → superreview+
Comment 12•22 years ago
|
||
cvs commit: Examining mozilla/netwerk/protocol/about/src Checking in mozilla/netwerk/protocol/about/src/nsAboutRedirector.cpp; /cvsroot/mozilla/netwerk/protocol/about/src/nsAboutRedirector.cpp,v <-- nsAboutRedirector.cpp new revision: 1.13; previous revision: 1.12
Comment 13•22 years ago
|
||
timeless: you did not checkin the mozilla/netwerk/build/nsNetModule.cpp part of the patch, intentionally?
Comment 14•22 years ago
|
||
Checking in mozilla/netwerk/build/nsNetModule.cpp; /cvsroot/mozilla/netwerk/build/nsNetModule.cpp,v <-- nsNetModule.cpp new revision: 1.83; previous revision: 1.82 because i wasn't really awake.
Assignee | ||
Comment 15•22 years ago
|
||
I kind of forgot to change the "about:" page to use the new about:logo. Should I provide a new patch or...?
Comment 16•22 years ago
|
||
Attachment #109031 -
Attachment is obsolete: true
Comment 17•22 years ago
|
||
If the about:logo mapping is checked in, can you mark this verified, set the milestone and create a new bug for patching the about: page? about: bugs are only networking bugs if they deal with the URL itself. The content bugs belong in XP-apps, and I don't QA that. I can verify the about:logo when 1.3b comes out, but I won't QA the change to the main about: page.
Comment 19•21 years ago
|
||
VERIFIED: Mozilla 1.3f, Win98 + Linux RH 7.3
Whiteboard: checkwin checklinux
Updated•21 years ago
|
Attachment #110950 -
Flags: review+
Updated•21 years ago
|
Attachment #110950 -
Flags: superreview?(jaggernaut)
Comment 20•21 years ago
|
||
Comment on attachment 110950 [details] [diff] [review] update about.xhtml sr=jag. Put this in a new bug as per benc's request.
Attachment #110950 -
Flags: superreview?(jaggernaut) → superreview+
Comment 21•21 years ago
|
||
spun off 207674
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•