Closed Bug 52104 Opened 25 years ago Closed 22 years ago

about:logo is missing

Categories

(Core :: Networking, defect, P3)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Future

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file, 2 obsolete files)

update about.xhtml
705 bytes, patch
caillon
: review+
jag+mozilla
: superreview+
Details | Diff | Splinter Review
about:logo should be hooked up to "chrome://global/content/logo.gif"
Target Milestone: --- → Future
Is this a single line fix or do we need a new protocol handler/method?
mass move, v2. qa to me.
QA Contact: tever → benc
Blocks: 96712
Why do we need that? I don't think we do.
well, I want it.
-> browser-general - this is not networking.
Component: Networking → Browser-General
about:logo is shorter than chrome://global/content/logo.gif :)
Attached patch patch. is this all? (obsolete) — — Splinter Review
Attachment #109029 - Attachment is obsolete: true
Attachment #109031 - Flags: review?(timeless)
Attachment #109031 - Flags: superreview?(darin)
Attachment #109031 - Flags: review?(timeless)
Attachment #109031 - Flags: review+
.
Assignee: gagan → bugzilla
Component: Browser-General → Networking
Comment on attachment 109031 [details] [diff] [review] still not sure if this is all...:) sr=darin
Attachment #109031 - Flags: superreview?(darin) → superreview+
cvs commit: Examining mozilla/netwerk/protocol/about/src Checking in mozilla/netwerk/protocol/about/src/nsAboutRedirector.cpp; /cvsroot/mozilla/netwerk/protocol/about/src/nsAboutRedirector.cpp,v <-- nsAboutRedirector.cpp new revision: 1.13; previous revision: 1.12
timeless: you did not checkin the mozilla/netwerk/build/nsNetModule.cpp part of the patch, intentionally?
Checking in mozilla/netwerk/build/nsNetModule.cpp; /cvsroot/mozilla/netwerk/build/nsNetModule.cpp,v <-- nsNetModule.cpp new revision: 1.83; previous revision: 1.82 because i wasn't really awake.
I kind of forgot to change the "about:" page to use the new about:logo. Should I provide a new patch or...?
Attachment #109031 - Attachment is obsolete: true
If the about:logo mapping is checked in, can you mark this verified, set the milestone and create a new bug for patching the about: page? about: bugs are only networking bugs if they deal with the URL itself. The content bugs belong in XP-apps, and I don't QA that. I can verify the about:logo when 1.3b comes out, but I won't QA the change to the main about: page.
VERIFIED Mac OS X, Mozilla 1.3b
Whiteboard: checkwin checklinux
VERIFIED: Mozilla 1.3f, Win98 + Linux RH 7.3
Whiteboard: checkwin checklinux
Attachment #110950 - Flags: superreview?(jaggernaut)
Comment on attachment 110950 [details] [diff] [review] update about.xhtml sr=jag. Put this in a new bug as per benc's request.
Attachment #110950 - Flags: superreview?(jaggernaut) → superreview+
Blocks: 207674
spun off 207674
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
VERIFIED/fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: