about:logo is missing

VERIFIED FIXED in Future

Status

()

P3
normal
VERIFIED FIXED
18 years ago
16 years ago

People

(Reporter: bugzilla, Assigned: bugzilla)

Tracking

Trunk
Future
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

18 years ago
about:logo should be hooked up to "chrome://global/content/logo.gif"

Updated

18 years ago
Target Milestone: --- → Future
(Assignee)

Comment 1

18 years ago
Is this a single line fix or do we need a new protocol handler/method?

Comment 2

18 years ago
mass move, v2.
qa to me.
QA Contact: tever → benc

Updated

17 years ago
Blocks: 96712

Comment 3

17 years ago
Why do we need that? I don't think we do.

Comment 4

17 years ago
well, I want it.

Comment 5

17 years ago
-> browser-general - this is not networking.
Component: Networking → Browser-General
about:logo is shorter than chrome://global/content/logo.gif :)
(Assignee)

Comment 8

16 years ago
Created attachment 109029 [details] [diff] [review]
patch. is this all?
(Assignee)

Comment 9

16 years ago
Created attachment 109031 [details] [diff] [review]
still not sure if this is all...:)
Attachment #109029 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Attachment #109031 - Flags: review?(timeless)

Updated

16 years ago
Attachment #109031 - Flags: superreview?(darin)
Attachment #109031 - Flags: review?(timeless)
Attachment #109031 - Flags: review+

Comment 10

16 years ago
.
Assignee: gagan → bugzilla
Component: Browser-General → Networking

Comment 11

16 years ago
Comment on attachment 109031 [details] [diff] [review]
still not sure if this is all...:)

sr=darin
Attachment #109031 - Flags: superreview?(darin) → superreview+

Comment 12

16 years ago
cvs commit: Examining mozilla/netwerk/protocol/about/src
Checking in mozilla/netwerk/protocol/about/src/nsAboutRedirector.cpp;
/cvsroot/mozilla/netwerk/protocol/about/src/nsAboutRedirector.cpp,v  <-- 
nsAboutRedirector.cpp
new revision: 1.13; previous revision: 1.12
timeless: you did not checkin the mozilla/netwerk/build/nsNetModule.cpp part of
the patch, intentionally?

Comment 14

16 years ago
Checking in mozilla/netwerk/build/nsNetModule.cpp;
/cvsroot/mozilla/netwerk/build/nsNetModule.cpp,v  <--  nsNetModule.cpp
new revision: 1.83; previous revision: 1.82

because i wasn't really awake.
(Assignee)

Comment 15

16 years ago
I kind of forgot to change the "about:" page to use the new about:logo. Should I
provide a new patch or...?

Comment 16

16 years ago
Created attachment 110950 [details] [diff] [review]
update about.xhtml
Attachment #109031 - Attachment is obsolete: true

Comment 17

16 years ago
If the about:logo mapping is checked in, can you mark this verified, set the
milestone and create a new bug for patching the about: page?

about: bugs are only networking bugs if they deal with the URL itself. The
content  bugs belong in XP-apps, and I don't QA that.

I can verify the about:logo when 1.3b comes out, but I won't QA the change to
the main about: page.

Comment 18

16 years ago
VERIFIED Mac OS X, Mozilla 1.3b
Whiteboard: checkwin checklinux

Comment 19

16 years ago
VERIFIED: Mozilla 1.3f, Win98 + Linux RH 7.3
Whiteboard: checkwin checklinux

Updated

16 years ago
Attachment #110950 - Flags: superreview?(jaggernaut)

Comment 20

16 years ago
Comment on attachment 110950 [details] [diff] [review]
update about.xhtml

sr=jag. Put this in a new bug as per benc's request.
Attachment #110950 - Flags: superreview?(jaggernaut) → superreview+

Updated

16 years ago
Blocks: 207674

Comment 21

16 years ago
spun off 207674
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 22

16 years ago
VERIFIED/fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.