52104 - about:logo is missing

Status: VERIFIED FIXED

Description

[Henrik Gemal]

about:logo should be hooked up to "chrome://global/content/logo.gif"

Comment 1

[Henrik Gemal]

Is this a single line fix or do we need a new protocol handler/method?

Comment 2

[benc]

mass move, v2.
qa to me.

Comment 3

[Ben Bucksch (:BenB)]

Why do we need that? I don't think we do.

Comment 4

[timeless]

well, I want it.

Comment 5

[benc]

-> browser-general - this is not networking.

Comment 6

[石庭豐 (Seak, Teng-Fong)]

about:logo is shorter than chrome://global/content/logo.gif :)

Comment 7

[Henrik Gemal]

isn't it just to add about:logo here
http://lxr.mozilla.org/mozilla/source/netwerk/protocol/about/src/nsAboutRedirector.cpp#68
and here:
http://lxr.mozilla.org/mozilla/source/netwerk/build/nsNetModule.cpp#851
?

Comment 8

[Henrik Gemal]

Created attachment 109029 [details] [diff] [review]
patch. is this all?

Comment 9

[Henrik Gemal]

Created attachment 109031 [details] [diff] [review]
still not sure if this is all...:)

Comment 10

[timeless]

.

Comment 11

[Darin Fisher]

Comment on attachment 109031 [details] [diff] [review]
still not sure if this is all...:)

sr=darin

Comment 12

[timeless]

cvs commit: Examining mozilla/netwerk/protocol/about/src
Checking in mozilla/netwerk/protocol/about/src/nsAboutRedirector.cpp;
/cvsroot/mozilla/netwerk/protocol/about/src/nsAboutRedirector.cpp,v  <-- 
nsAboutRedirector.cpp
new revision: 1.13; previous revision: 1.12

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

timeless: you did not checkin the mozilla/netwerk/build/nsNetModule.cpp part of
the patch, intentionally?

Comment 14

[timeless]

Checking in mozilla/netwerk/build/nsNetModule.cpp;
/cvsroot/mozilla/netwerk/build/nsNetModule.cpp,v  <--  nsNetModule.cpp
new revision: 1.83; previous revision: 1.82

because i wasn't really awake.

Comment 15

[Henrik Gemal]

I kind of forgot to change the "about:" page to use the new about:logo. Should I
provide a new patch or...?

Comment 16

[timeless]

Created attachment 110950 [details] [diff] [review]
update about.xhtml

Comment 17

[benc]

If the about:logo mapping is checked in, can you mark this verified, set the
milestone and create a new bug for patching the about: page?

about: bugs are only networking bugs if they deal with the URL itself. The
content  bugs belong in XP-apps, and I don't QA that.

I can verify the about:logo when 1.3b comes out, but I won't QA the change to
the main about: page.

Comment 18

[benc]

VERIFIED Mac OS X, Mozilla 1.3b

Comment 19

[benc]

VERIFIED: Mozilla 1.3f, Win98 + Linux RH 7.3

Comment 20

[jag (Peter Annema)]

Comment on attachment 110950 [details] [diff] [review]
update about.xhtml

sr=jag. Put this in a new bug as per benc's request.

Comment 21

[timeless]

spun off 207674

Comment 22

[benc]

VERIFIED/fixed.