521130 - Add ability to set per-test timeout to mochitest

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Jonathan Griffin (:jgriffin)]

In order to successfully run mochitest with valgrind and purify, we need the ability to set the mochitest per-test timeout dynamically.  Currently, it's hardcoded to 5 minutes.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: patch

This patch adds a --timeout parameter to runtests.py, which sets the per-test timeout to the specified number of minutes.  E.g., --timeout=15 to specify a 15-minute timeout.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 405168 [details] [diff] [review]
patch

This looks fine, except the --timeout parameter Joel added to runreftest.py in bug 471579 is in milliseconds, so we should make this one take the same units.

Comment 3

[(not currently active) Ted Mielczarek]

(I was looking for this because I wanted to use the timeout value in my patch on bug 501034)

Comment 4

[Jeff Walden [:Waldo]]

Millisecond-level precision seems unwarranted here; I'd rather see seconds both places if we're interested in consistency.

Comment 5

[Jonathan Griffin (:jgriffin)]

Attachment: patch v2

Here's a patch which uses a second-based timeout for both reftest and mochitest.  Ted, is there anything that depends on the reftest timeout being in ms, that would need to be changed due to this patch?

Comment 6

[Jonathan Griffin (:jgriffin)]

Attachment: patch v3

Fixed a bug in the previous patch related to the default reftest timeout

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 406478 [details] [diff] [review]
patch v3

Beats me. Ask Joel?

Comment 8

[Jonathan Griffin (:jgriffin)]

Joel: there's a request to change the runreftest.py timeout from ms to seconds, see patch v3 and comments #2 and #4 above.  Will this cause any problems for you?

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

I am fine with seconds, I just need to know when we change it so I can adjust the mobile automation accordingly.

Comment 10

[Jonathan Griffin (:jgriffin)]

I'll plan to push it to trunk Friday morning if that's ok with you.

Comment 11

[Jonathan Griffin (:jgriffin)]

Pushed as http://hg.mozilla.org/mozilla-central/rev/e8bc0e76d7e9