521151 - /content/ unit tests fail on JavaScript 'strict' mode

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jae-Seong Lee-Russo]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091007 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091007 Minefield/3.7a1pre (.NET CLR 3.5.30729)

$ make -C content/test/ xpcshell-tests
make: Entering directory `/c/mozilla-build/mozilla-central/content/test'
c:/mozilla-build/python25/python2.5.exe -u /c/mozilla-build/mozilla-central/conf
ig/pythonpath.py \
          -I/c/mozilla-build/mozilla-central/build \
          /c/mozilla-build/mozilla-central/testing/xpcshell/runxpcshelltests.py
\
          --symbols-path=../../dist/crashreporter-symbols \
          ../../dist/bin/xpcshell \
          ../../_tests/xpcshell/test_content/unit
TEST-UNEXPECTED-FAIL | c:\mozilla-build\mozilla-central\_tests\xpcshell\test_con
tent\unit\test_isequalnode.js | test failed (with xpcshell return code: 0), see
following log:
  >>>>>>>
  TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-PASS | c:/mozilla-build/mozilla-central/_tests/xpcshell/test_content/unit/h
ead_content.js | [ParseFile : 76] true == true
TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | TypeError: assignment to undeclared
variable fileStr

  <<<<<<<
TEST-UNEXPECTED-FAIL | c:\mozilla-build\mozilla-central\_tests\xpcshell\test_con
tent\unit\test_nodelist.js | test failed (with xpcshell return code: 0), see fol
lowing log:
  >>>>>>>
  TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-PASS | c:/mozilla-build/mozilla-central/_tests/xpcshell/test_content/unit/h
ead_content.js | [ParseFile : 76] true == true
TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | TypeError: assignment to undeclared
variable fileStr

  <<<<<<<
TEST-UNEXPECTED-FAIL | c:\mozilla-build\mozilla-central\_tests\xpcshell\test_con
tent\unit\test_normalize.js | test failed (with xpcshell return code: 0), see fo
llowing log:
  >>>>>>>
  TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-PASS | c:/mozilla-build/mozilla-central/_tests/xpcshell/test_content/unit/h
ead_content.js | [ParseFile : 76] true == true
TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | TypeError: assignment to undeclared
variable fileStr

  <<<<<<<
TEST-UNEXPECTED-FAIL | c:\mozilla-build\mozilla-central\_tests\xpcshell\test_con
tent\unit\test_range.js | test failed (with xpcshell return code: 0), see follow
ing log:
  >>>>>>>
  TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-PASS | c:/mozilla-build/mozilla-central/_tests/xpcshell/test_content/unit/t
est_range.js | [getParsedDocument : 219] true == true
TEST-PASS | c:/mozilla-build/mozilla-central/_tests/xpcshell/test_content/unit/t
est_range.js | [getParsedDocument : 220] true == true
TEST-PASS | c:/mozilla-build/mozilla-central/_tests/xpcshell/test_content/unit/t
est_range.js | [getParsedDocument : 221] true == true
TEST-PASS | c:/mozilla-build/mozilla-central/_tests/xpcshell/test_content/unit/t
est_range.js | [getParsedDocument : 222] true == true
TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | TypeError: assignment to undeclared
variable i

  <<<<<<<
TEST-PASS | c:\mozilla-build\mozilla-central\_tests\xpcshell\test_content\unit\t
est_treewalker.js | test passed
TEST-PASS | c:\mozilla-build\mozilla-central\_tests\xpcshell\test_content\unit\t
est_xml_parser.js | test passed
TEST-PASS | c:\mozilla-build\mozilla-central\_tests\xpcshell\test_content\unit\t
est_xml_serializer.js | test passed
INFO | Result summary:
INFO | Passed: 3
INFO | Failed: 4
make: *** [xpcshell-tests] Error 1
make: Leaving directory `/c/mozilla-build/mozilla-central/content/test'

Reproducible: Always

Steps to Reproduce:
1. Run the xpcshell test with the '-S' option

Actual Results:  
Failed

Expected Results:  
Passed

Comment 1

[Jae-Seong Lee-Russo]

Attachment: Fix the errors

Comment 2

[Jae-Seong Lee-Russo]

Attachment: Convert to UNIX newline

Comment 3

[Jae-Seong Lee-Russo]

Attachment: /content/ unit tests fail on JS strict mode

Comment 4

[Jae-Seong Lee-Russo]

Comment on attachment 409426 [details] [diff] [review]
/content/ unit tests fail on JS strict mode

Darin Fisher, can you review head_content.js?

Olli Pettay, please review test_range.js & xtfComponent.js.

Comment 5

[Jae-Seong Lee-Russo]

Comment on attachment 409426 [details] [diff] [review]
/content/ unit tests fail on JS strict mode

I just found Darin no longer reviews.

Jeff, please review head_content.js.

Comment 6

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/mozilla-central/rev/c78659e72a1a

Thanks again!

Comment 7

[Nochum Sossonko [:Natch]]

Pushed to 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/bf15ba83f27c

Is this really clear to land on 1.9.2? No approval necessary?

Comment 8

[Nochum Sossonko [:Natch]]

Clearing checkin keywords since these patches don't have 1.9.1 approval. Please request approval on the patches, and once granted, replace the checkin keyword.