Closed
Bug 521154
Opened 16 years ago
Closed 16 years ago
xpcshell-tests: test_streamupdater hangs with 'strict' & 'werror' on
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
Firefox 3.7a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | final-fixed |
People
(Reporter: lusian, Assigned: lusian)
References
Details
Attachments
(1 file)
1.02 KB,
patch
|
tony
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091007 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091007 Minefield/3.7a1pre (.NET CLR 3.5.30729)
$ make SOLO_FILE="test_streamupdater.js" -C toolkit/components/url-classifier/t
ests/ check-one
...
TEST-PASS | c:/mozilla-build/mozilla-central/_tests/xpcshell/test_url-classifier
/unit/head_urlclassifier.js | [anonymous : 185] test-malware-simple == test-malw
are-simple
running function testValidMAC() {
var addUrls = ["foo.com/a", "foo.com/b", "bar.com/c"];
var update = buildPhishingUpdate([{chunkNum: 1, urls: addUrls}]);
update = "m:" + MAC(update, gClientKeyRaw) + "\n" + update;
var assertions = {tableData: "test-phish-simple;a:1", urlsExist: addUrls};
doTest([update], assertions, false, gClientKey);
}
Reproducible: Always
Steps to Reproduce:
1. Run the xpcshell test with the '-S' option
Actual Results:
Hang
Expected Results:
Passed
Assignee | ||
Comment 1•16 years ago
|
||
Assignee | ||
Updated•16 years ago
|
Attachment #405194 -
Flags: review?(mlconnor)
Updated•16 years ago
|
Assignee: nobody → lusian
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•16 years ago
|
Attachment #405194 -
Flags: review?(mlconnor) → review?(tony)
Comment 2•16 years ago
|
||
Comment on attachment 405194 [details] [diff] [review]
Fix the hang
looks fine
Attachment #405194 -
Flags: review?(tony) → review+
Updated•16 years ago
|
Keywords: checkin-needed
Comment 3•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/eb95f58aec0f
please use UNIX newlines for next patches.
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Updated•16 years ago
|
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [c-n: m-1.9.2, m-1.9.1]
Version: unspecified → Trunk
Comment 4•16 years ago
|
||
Pushed to 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/6cec8057be40
status1.9.2:
--- → final-fixed
Whiteboard: [c-n: m-1.9.2, m-1.9.1] → [c-n: m-1.9.1]
Comment 5•16 years ago
|
||
Clearing checkin keywords since these patches don't have 1.9.1 approval. Please request approval on the patches, and once granted, replace the checkin keyword.
Keywords: checkin-needed
Whiteboard: [c-n: m-1.9.1]
Updated•11 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•