521154 - xpcshell-tests: test_streamupdater hangs with 'strict' & 'werror' on

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Jae-Seong Lee-Russo]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091007 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091007 Minefield/3.7a1pre (.NET CLR 3.5.30729)

$ make SOLO_FILE="test_streamupdater.js" -C toolkit/components/url-classifier/t
ests/ check-one
...
TEST-PASS | c:/mozilla-build/mozilla-central/_tests/xpcshell/test_url-classifier
/unit/head_urlclassifier.js | [anonymous : 185] test-malware-simple == test-malw
are-simple
running function testValidMAC() {
    var addUrls = ["foo.com/a", "foo.com/b", "bar.com/c"];
    var update = buildPhishingUpdate([{chunkNum: 1, urls: addUrls}]);
    update = "m:" + MAC(update, gClientKeyRaw) + "\n" + update;
    var assertions = {tableData: "test-phish-simple;a:1", urlsExist: addUrls};
    doTest([update], assertions, false, gClientKey);
}


Reproducible: Always

Steps to Reproduce:
1. Run the xpcshell test with the '-S' option
Actual Results:  
Hang

Expected Results:  
Passed

Comment 1

[Jae-Seong Lee-Russo]

Attachment: Fix the hang

Comment 2

[Tony Chang (Google)]

Comment on attachment 405194 [details] [diff] [review]
Fix the hang

looks fine

Comment 3

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/eb95f58aec0f

please use UNIX newlines for next patches.

Comment 4

[Nochum Sossonko [:Natch]]

Pushed to 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/6cec8057be40

Comment 5

[Nochum Sossonko [:Natch]]

Clearing checkin keywords since these patches don't have 1.9.1 approval. Please request approval on the patches, and once granted, replace the checkin keyword.