Closed
Bug 521182
Opened 15 years ago
Closed 15 years ago
remove -arch:SSE2 from crtvc9sp1.diff
Categories
(Core :: Memory Allocator, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
People
(Reporter: ayakawa.m, Assigned: ayakawa.m)
References
Details
Attachments
(1 file)
497 bytes,
patch
|
ted
:
review+
ted
:
approval1.9.2+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.2b1pre) Gecko/20091005 Namoroka/3.6b1pre (ayakawa PGU)
Build Identifier:
now, crtvc9sp1.diff have -arch:SSE2 option at makefile.sub.patch.
we need to remove this.
Reproducible: Always
Assignee | ||
Comment 1•15 years ago
|
||
Comment 2•15 years ago
|
||
Comment on attachment 405218 [details] [diff] [review]
remove -arch:SSE2 from crtvc9sp1.diff
-arch:sse2 cause binary is generated using SSE2. We should remove this option to work on non-SSE2 machine although VC9 doesn't use by office build.
Attachment #405218 -
Flags: review?(ted.mielczarek)
Updated•15 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•15 years ago
|
Component: Build Config → jemalloc
QA Contact: build-config → jemalloc
Version: unspecified → Trunk
Updated•15 years ago
|
Attachment #405218 -
Flags: review?(ted.mielczarek) → review+
Updated•15 years ago
|
Assignee: nobody → ayakawa.m
Keywords: checkin-needed
Comment 3•15 years ago
|
||
Comment on attachment 405218 [details] [diff] [review]
remove -arch:SSE2 from crtvc9sp1.diff
Please land this on 1.9.2 as well, since bug 416117 landed there.
Attachment #405218 -
Flags: approval1.9.2+
Comment 4•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/32381d6bc4d5
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5f0ad64bc6e6
# I hope that you'll set the real name setting of the bugzilla :-)
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
status1.9.2:
--- → beta1-fixed
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•