Closed
Bug 521265
Opened 15 years ago
Closed 15 years ago
10/8 trunk nightly - aero peek not working / js console errors
Categories
(Firefox :: General, defect, P1)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: jimm, Unassigned)
References
Details
Now that the jsm is getting loaded, I'm still not seeing aero peek on trunk. The following js error shows up twice when I open a new tab:
Error: tab is undefined
Source File: file:///C:/Program%20Files/Minefield/modules/WindowsPreviewPerTab.jsm
Line: 514
in
onLinkIconAvailable: function (aBrowser) {
let img = getFaviconAsImage(aBrowser.mIconURL);
for each (let tab in this.tabbrowser.mTabs)
if (tab.linkedBrowser == aBrowser)
this.previewFromTab(tab).icon = img;
}
Next I have to try the 1.9.2 build.
Reporter | ||
Comment 1•15 years ago
|
||
Doesn't appear to be working in 1.9.2 either, although I don't see any script errors.
Reporter | ||
Updated•15 years ago
|
Flags: blocking-firefox3.6?
Reporter | ||
Comment 2•15 years ago
|
||
For 1.9.2, venkman doesn't show the module as being loaded. Looking at the script - shouldn't #define WIN7_FEATURES be set prior to it's use? I'm not sure how this is working.
http://mxr.mozilla.org/mozilla1.9.2/source/browser/base/content/browser.js#6278
http://mxr.mozilla.org/mozilla1.9.2/source/browser/base/content/browser.js#1358
cc'ing Dao as I am not a browser scripting expert.
Reporter | ||
Comment 3•15 years ago
|
||
Looks like bug 521216 is dealing with the tab errors on trunk.
Reporter | ||
Comment 4•15 years ago
|
||
Possible dupe of bug 521188?
Comment 5•15 years ago
|
||
(In reply to comment #4)
> Possible dupe of bug 521188?
Not really, but that would fix it, since it gets rid of the WIN7_FEATURES define.
Depends on: 521188
Updated•15 years ago
|
Priority: -- → P1
Updated•15 years ago
|
Component: Tabbed Browser → General
QA Contact: tabbed.browser → general
Comment 6•15 years ago
|
||
The WIN7_FEATURES define isn't an issue on trunk though, so there's still something else wrong.
Reporter | ||
Comment 7•15 years ago
|
||
(In reply to comment #6)
> The WIN7_FEATURES define isn't an issue on trunk though, so there's still
> something else wrong.
For some reason that lazy getter ended up lower on 1.9.2, it's above all the other stuff on trunk.
http://mxr.mozilla.org/mozilla1.9.2/source/browser/base/content/browser.js#6278
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#134
I guess there's no need for a fix though if bug 521188 is going to land on both.
Reporter | ||
Comment 8•15 years ago
|
||
This might also explain why the trunk/XP/Ts regression hasn't shown up on 1.9.2 yet.
Comment 9•15 years ago
|
||
So will this be resolved by bug 521188? Not sure I can block on a trunk-only bug.
Flags: blocking-firefox3.6? → blocking-firefox3.6-
Comment 10•15 years ago
|
||
Not sure what the issue on trunk is. Comment 2 is branch-only and solved by bug 521188.
Reporter | ||
Comment 11•15 years ago
|
||
Thanks to other landings, this is now WFM.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•