I should mention exactly what I did before the crash from comment #1. It sometimes takes a little work to reproduce. 1) Loaded Sun's Clock demo applet (http://java.sun.com/applets/jdk/1.4/demo/applets/Clock/example1.html). 2) Opened another tab and loaded another copy of the Clock applet. 3) Opened another tab and loaded the NOAA weather applet (http://radar.weather.gov/radar.php?rid=LOT&product=NCR&overlay=11101111&loop=yes). 4) Opened another (fourth) tab and tried to load http://poslfit.homeip.net/test/liveconnecttest.html. The crash happened as this page was loading. Switching away from the browser and back again may also sometimes trigger a crash.
(In reply to comment #0) > My patch for bug 517355 has been more-or-less complete for a while, > and worked fine before the patch for bug 511425 landed. But since > then my patch crashes whenever a Java applet is loaded (usually > shortly afterwards). (See bug 517355 comment #38 and bug 517355 > comment #44.) To be clear, the fix for the bustage that bug 517355 caused was pretty easy to fix. The most recent crash is because of the pseudo-frame that liveconnect tries to build. Given how hard it has been for us to get the JS engine's own pseudo frame up and running without bugs, I'm working on a patch to rid liveconnect of its pseudo-frame.
http://hg.mozilla.org/users/smichaud_pobox.com/bugzilla517355/rev/e847bbc68071 is my retreat from comment 3, but fixes the crash that smichaud saw.
Do we think this blocks beta? I'm pretty sure it blocks final release ... if it's to be considered a beta blocker, please switch the priority to P1.
Priority: -- → P2
> Do we think this blocks beta? I think it does, since it blocks bug 517355. Despite my previous comment, I think my tests are going reasonably well. I'll continue with them.
Priority: P2 → P1
I've now tested around 10 applets (among those that I normally use to test JEP releases) on OS X 10.5.8, OS X 10.6.1 and OS X 10.4.11 (the last on a PPC Mac). This includes this bug's URL, and several other applets that use Liveconnect. I didn't see any more crashes. I did have issues in a couple of applets (only in Namoroka) with mouse clicks not triggering their actions. But this is almost certainly unrelated to Liveconnect. I'll open another bug on this. I don't think its a beta blocker. As far as I'm concerned, this bug is now fixed, and its patches can land on the 1.9.2 branch. So also can my patch for bug 517355. We need to get this bug's patches posted and reviewed. But I'm not sure what the next step after that should be. Should my patch for bug 517355 and this bug's patch(es) be landed separately, or should they be combined into a single patch?
I consolidated these using the following command in my repo: hg diff -r 0dff27bfb277
Attachment #405539 - Flags: review?(gal)
Comment on attachment 405539 [details] [diff] [review] mrbkap's 5 patches to my user repo, consolidated > #ifdef OJI >-JS_BEGIN_EXTERN_C >-JS_FORCES_STACK JS_EXTERN_API(void) >-js_LeaveTraceLC(JSContext *cx); >-JS_END_EXTERN_C > #endif Empty ifdef.
Attachment #405539 - Flags: review?(gal) → review+
Comment on attachment 405539 [details] [diff] [review] mrbkap's 5 patches to my user repo, consolidated Landed (with gal's fix) on the 1.9.2 branch, together with my patch for bug 517355: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3861fd3d6671
(Following up comment #8) > I did have issues in a couple of applets (only in Namoroka) with > mouse clicks not triggering their actions. But this is almost > certainly unrelated to Liveconnect. I'll open another bug on this. > I don't think its a beta blocker. I now have a hunch this is Java-specific, and has to do with the JEP's underpinnings for the Java AppletContext.showDocument() method. I tested quite a lot with my DebugEventsPlugin from bug 441880, and couldn't see anything that would explain this behavior. I'll open a new bug once I've had a chance to debug this in the JEP.
Verified fixed on the 1.9.2 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2b6pre) Gecko/20091223 Namoroka/3.6b6pre and the site: http://poslfit.homeip.net/test/liveconnecttest.html.
You need to log in before you can comment on or make changes to this bug.