521359 - Stop firing load and loadend events and don't use NETWORK_LOADING state

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We're currently firing 'load' incorrectly, since the spec says 'load' should only be fired on media elements if we guarantee that no network traffic will ever be needed for this element in the future, and we never guarantee that. I think we'll get a consensus on WHATWG that 'load' should actually be removed from the spec, but we should change our behaviour ASAP so authors stop relying on it before it's too late. There is no guarantee that 'load' will ever fire, anyway, and authors relying on it are probably doing so incorrectly.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think we should get a simple patch here in for 1.9.2.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(We're also calculating the 'bytes downloaded' in progress events incorrectly, but I don't propose fixing that in 1.9.2.)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Stop tests from depending on 'load' or NETWORK_LOADED

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This stops us firing "load' or entering NETWORK_LOADED. Simple enough.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 405448 [details] [diff] [review]
fix

This isn't good enough, we need to fire a "suspend" event when we finish the load and currently we don't.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix v2

This is better. Fire "suspend" and also set the state to NETWORK_IDLE, since it is actually idle.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in:
http://hg.mozilla.org/mozilla-central/rev/2835e2bdb8fc
http://hg.mozilla.org/mozilla-central/rev/0f477bf03978

Plus follow fixes to various tests I missed, including a few abortive attempts at fixing test_videocontrols:
http://hg.mozilla.org/mozilla-central/rev/d71b94c523e0
http://hg.mozilla.org/mozilla-central/rev/9183971cc84f
http://hg.mozilla.org/mozilla-central/rev/04b1081dbb5d
http://hg.mozilla.org/mozilla-central/rev/4046f3843bdb

Comment 8

[Eric Shepherd [:sheppy]]

Updated the doc here:

https://developer.mozilla.org/En/Using_audio_and_video_in_Firefox#Media_events

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Pushed to 1.9.2:

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3a2ef681ffff
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b5456784e4fa
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d71f845415a1
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1f9bee9b8340
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ddf0e66e8ed4
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/8054426b6e59

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to comment #9)
> Pushed to 1.9.2:

Turns out we've already branched of 1.9.2 for beta 1, so this fix won't show up on 1.9.2 until a release after the beta. status-1.9.2 -> final-fixed.