521373 - Create an object-before_create hook

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

In general, it's pretty silly to have a before_create hook for each individual subclass of Bugzilla::Object, because before_create in the subclass would happen at the same time as before_create in Bugzilla::Object. People can just use $class->isa() to determine what class they're updating, using one central hook.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Comment 2

[Max Kanat-Alexander]

Attachment: v2

Had forgotten to include "use Bugzilla::Hook" in the first patch.

Comment 3

[Max Kanat-Alexander]

Attachment: v3

I moved it to check_required_create_fields because that way it will affect Bugzilla::Bug and anything else that uses the three internal subroutines instead of calling SUPER::create.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 407913 [details] [diff] [review]
v3

I can see where this would be very useful. I wrote a test extension and this worked pretty much as expected. r=dkl

Comment 5

[Max Kanat-Alexander]

Checking in Bugzilla/Hook.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Hook.pm,v  <--  Hook.pm
new revision: 1.34; previous revision: 1.33
done
Checking in Bugzilla/Object.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Object.pm,v  <--  Object.pm
new revision: 1.38; previous revision: 1.37
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/extensions/example/code/object-before_create.pl,v
done
Checking in extensions/example/code/object-before_create.pl;
/cvsroot/mozilla/webtools/bugzilla/extensions/example/code/object-before_create.pl,v  <--  object-before_create.pl
initial revision: 1.1
done