521476 - js_PopInterpFrame should eagerly release marks

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Note this basically reverts bug 521210.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 405564 [details] [diff] [review]
fix

No perf effects, I trust.

/be

Comment 3

[Brendan Eich [:brendan]]

(In reply to comment #1)
> Created an attachment (id=405564) [details]
> fix
> 
> Note this basically reverts bug 521210.

That must be a typo'ed bug id -- which one do you mean, the one where there was something live being released? That was (IIRC you said) fixed, so this bug has a good cause for reverting. Just confirming,

/be

Comment 4

[Brendan Eich [:brendan]]

Should this depend on bug 521309 (already landed), or block it (so this comes long to a branch with that one)?

/be

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Yes sorry I meant bug 520210 - and this should block bug 521309.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/tracemonkey/rev/29edaeea1f67

Comment 7

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/29edaeea1f67