The default bug view has changed. See this FAQ.

Unwanted shortcuts in Mark dropdown of Mail Toolbar

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
MailNews: Message Display
--
trivial
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Hb, Assigned: rsx11m)

Tracking

({fixed-seamonkey2.0.1, polish})

Trunk
seamonkey2.1a1
fixed-seamonkey2.0.1, polish
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.56 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5pre) Gecko/20091009 Lightning/1.0pre SeaMonkey/2.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5pre) Gecko/20091009 Lightning/1.0pre SeaMonkey/2.0pre (Linux is affected too)

Current user interface guidelines say that toolbar buttons should not have hints for keyboard shortcuts.

Reproducible: Always

Steps to Reproduce:
The Mark button in Mail Toolbar incorrectly shows shortcuts. All other buttons in the toolbar don't show them.
Actual Results:  
This is only a glitch in the UI. Mail display itself is not affected (Bug 521591).
Flags: wanted-seamonkey2.0?
Keywords: polish
Version: unspecified → Trunk
(Assignee)

Comment 1

8 years ago
Taking, I'll have a patch later today.
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Hardware: x86 → All
(Assignee)

Comment 2

8 years ago
Created attachment 409446 [details] [diff] [review]
Easy fix
[Checkin: Comments 5 & 6]

Patch to remove the "key" attributes from the menu list for button-markPopup.
The keyboard shortcuts themselves remain functional, only their display in the button's context menu is omitted.

This patch should be simple enough to qualify for a combined r/sr? request.
Attachment #409446 - Flags: superreview?(neil)
Attachment #409446 - Flags: review?(neil)

Updated

8 years ago
Attachment #409446 - Flags: superreview?(neil)
Attachment #409446 - Flags: superreview+
Attachment #409446 - Flags: review?(neil)
Attachment #409446 - Flags: review+
(Assignee)

Comment 3

8 years ago
Comment on attachment 409446 [details] [diff] [review]
Easy fix
[Checkin: Comments 5 & 6]

Thanks Neil. Requesting approval for 2.0.1, it's a trivial change affecting appearance only, no string or feature changes. No obvious risk involved.
Attachment #409446 - Flags: approval-seamonkey2.0.1?

Updated

8 years ago
Attachment #409446 - Flags: approval-seamonkey2.0.1? → approval-seamonkey2.0.1+
(Assignee)

Comment 4

8 years ago
Push for comm-central and comm-1.9.1, please (does not affect Thunderbird);
I'm canceling the pending wanted-sm2.0? request as this got 2.0.1 approval.
Flags: wanted-seamonkey2.0?
Keywords: checkin-needed
Whiteboard: [c-n: comm-central & comm-1.9.1]
Comment on attachment 409446 [details] [diff] [review]
Easy fix
[Checkin: Comments 5 & 6]


http://hg.mozilla.org/comm-central/rev/791c8ec2f336
Attachment #409446 - Attachment description: Easy fix → Easy fix [Checkin: Comment 5]
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central & comm-1.9.1] → [c-n: c-1.9.1]
Target Milestone: --- → seamonkey2.1a1

Comment 6

8 years ago
Comment on attachment 409446 [details] [diff] [review]
Easy fix
[Checkin: Comments 5 & 6]

http://hg.mozilla.org/releases/comm-1.9.1/rev/0e1adb3b9ac8
Attachment #409446 - Attachment description: Easy fix [Checkin: Comment 5] → Easy fix [Checkin: Comments 5 & 6]

Updated

8 years ago
Keywords: checkin-needed → fixed-seamonkey2.0.1
Whiteboard: [c-n: c-1.9.1]
You need to log in before you can comment on or make changes to this bug.