"Help" item in the menu bar should be different between Windows and other platforms for some locales

VERIFIED FIXED in seamonkey2.1a1

Status

SeaMonkey
OS Integration
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Cédric Corazza, Assigned: Cédric Corazza)

Tracking

({l12y})

Trunk
seamonkey2.1a1
x86
Windows XP
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

8 years ago
Created attachment 405760 [details] [diff] [review]
Patch for Help item menu

For the french localisation we need to have a different "Help" menu between
Windows and Unix/Mac.
In French Windows, all the programs have an "?" item menu instead of "Help". Other French localized Mozilla products use "?" for the Help item (cf. https://bugzilla.mozilla.org/show_bug.cgi?id=247842 and https://bugzilla.mozilla.org/show_bug.cgi?id=228163).
It would be nice to have it in SeaMonkey 2.1
Attachment #405760 - Flags: review?
(Assignee)

Comment 1

8 years ago
Created attachment 405771 [details] [diff] [review]
Patch for Help item menu without #ifdef
Attachment #405760 - Attachment is obsolete: true
Attachment #405771 - Flags: review?
Attachment #405760 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #405771 - Flags: review? → review?(neil)

Updated

8 years ago
Attachment #405771 - Flags: review?(neil) → review-

Comment 2

8 years ago
Comment on attachment 405771 [details] [diff] [review]
Patch for Help item menu without #ifdef

It turns out that we can do better than this!

Because utilityOverlay.xul already includes platformCommunicatorOverlay.dtd as well as utilityOverlay.dtd, you can override any* utilityOverlay.xul string on a platform-specific basis by adding it to platformCommunicatorOverlay.dtd too.

i.e. in your locale, simply add this to win/platformCommunicatorOverlay.dtd:
<!-- Help viewer -->
<!ENTITY helpMenu.label                 "?">
<!ENTITY helpMenu.accesskey             "?">

(*The exceptions are the Edit menu entries in the bookmarks and history windows, because they use utilityOverlay.dtd directly.)
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
OK. But compare-locales script won't be happy with this. Though, the build process should start even if there are obsolete strings (strings not in en-US). But I'm not sure of this. That will also make the fr SeaMonkey tinderboxes forever orange.
(Assignee)

Comment 4

8 years ago
Created attachment 405776 [details] [diff] [review]
Alternate patch

This is an alternate patch with less code and which won't break the build process and the tinderboxes wrt comment#2
Attachment #405776 - Flags: review?(neil)

Updated

8 years ago
Attachment #405776 - Flags: review?(neil) → review+

Comment 5

8 years ago
Comment on attachment 405776 [details] [diff] [review]
Alternate patch

>+<!-- LOCALIZATION NOTE some localizations of Windows use "?"
>+                       for the help button in the menubar but Gnome does not.   -->
Nit: This is a platform file, so I'm not sure that you need to mention Gnome.
Maybe something like
<!-- LOCALIZATION NOTE some localizations change the help label on Windows -->

>+<!ENTITY helpMenu.label                 "Help"> 
>+<!ENTITY helpMenu.accesskey             "H">
Nit: Please add these to the Help Viewer section as I indicated previously.

r=me with those fixed.
(Assignee)

Comment 6

8 years ago
Created attachment 405785 [details] [diff] [review]
Final patch addressing Neil's comments
[Checkin: Comment 11]
Attachment #405771 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Whiteboard: [checkin-needed sm2.1]
(Assignee)

Comment 7

8 years ago
(In reply to comment #7)
> It would be nice to have it in SeaMonkey 2.1
I wanted to say SeaMonkey 2.0.1
Whiteboard: [checkin-needed sm2.1] → [checkin-needed sm2.0.1]

Comment 8

8 years ago
(In reply to comment #7)
> (In reply to comment #7)
> > It would be nice to have it in SeaMonkey 2.1
> I wanted to say SeaMonkey 2.0.1

You need to ask for "approval‑seamonkey2.0.1" (click the "details" link, then set the "?" flag on the attachment, and comment on the risk and why you want this on 2.0.1).
Whiteboard: [checkin-needed sm2.0.1]
(Assignee)

Comment 9

8 years ago
Comment on attachment 405785 [details] [diff] [review]
Final patch addressing Neil's comments
[Checkin: Comment 11]

I tested the patch and it worked fine.
It would be nice to have so that we have consistent UI across Mozilla products.
Attachment #405785 - Flags: approval-seamonkey2.0.1?

Comment 10

8 years ago
Comment on attachment 405785 [details] [diff] [review]
Final patch addressing Neil's comments
[Checkin: Comment 11]

Umm, Cedric, as a localizer you should know that we can't take L10n changes in a stable branch.
Attachment #405785 - Flags: approval-seamonkey2.0.1? → approval-seamonkey2.0.1-
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Comment on attachment 405785 [details] [diff] [review]
Final patch addressing Neil's comments
[Checkin: Comment 11]


http://hg.mozilla.org/comm-central/rev/e0fb72d64bfe
Attachment #405785 - Attachment description: Final patch addressing Neil's comments → Final patch addressing Neil's comments [Checkin: Comment 11]
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
Attachment #405776 - Attachment is obsolete: true
(Assignee)

Comment 12

8 years ago
VERIFIED
Name=SeaMonkey
Version=2.1a1pre
BuildID=20091104002950
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.