521734 - Clean-up Security section

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, enhancement)

Description

[Robert Samuels]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)

Create sub-nav for [http://www-stage.mozilla.org/security/ Security] section?


Reproducible: Always

Comment 1

[David Boswell]

The Security Advisories page could use some general clean-up, including:

* Adding breadcrumbs
* Removing out of date default left nav
* Adding a new Security section specific left nav or improve linking some other way (perhaps a sidebar)
* Have a promo or call-out to documentation that helps people know how to upgrade their software to get these security patches
* Removing any old content in directory -- which pages are still relevant?

Comment 2

[David Boswell]

This would be a good bug for someone who wants to learn about how to edit the site, so I'm marking this as a bug I'm happy to provide mentorship on.  

If anyone is interested in this, comment in this bug and I'll walk you through what is involved with this and how to submit edits, test them and make them live.

Comment 3

[Sudheendra]

HI  David , i am interested in taking up this task. 
i am a new to mozilla open source can  you please guide me through this task.
my  mail id :  [e-mail]
Thanks,
Sudheendra.

Comment 4

[David Boswell]

Sudheendra, that's great!  

As a starting point, there is some general information about how to work with the mozilla.org site on the wiki at:

https://wiki.mozilla.org/Mozilla.org/How_to_Work_with_Site

It will be good to have some familiarity with how the site is coded, where the code is and how to work with it before starting on this particular bug.  For example, checking out the source files from Subversion will let you work on any part of the site.

After looking over those instructions, a good next step would be for us to talk more about the specifics of this bug.  Feel free to find me on our IRC server at irc.mozilla.org (I'm davidwboswell there) and I hang out in #siteplanning often.  Or we could continue to talk through things in this bug.

Comment 5

[David Boswell]

Adding some notes about the basic steps for this bug:

* Create a new Security sub-nav in the LeftMenu.php file (for starters it could just be a couple of links like: Vulnerabilities, Advisories.  We can figure out the exact links later in the process).

http://viewvc.svn.mozilla.org/vc/projects/mozilla.org/branches/staging/includes/MozillaOrg/LeftMenu.php?view=log

* Convert the current mozilla.org/security pages to the new site template that will be able to pull-in the new side nav.  Instructions for this are at:

https://wiki.mozilla.org/Mozilla.org/Page_conversion

* When we get to this point, we'll ask the owners of these pages to review on stage and get their input about what the nav should link to.  There are a lot of files in the security section and not all of them may be active, plus there are pages in other sections of the site that we may want to link to (specifically the mozilla.org/projects/security pages).

http://viewvc.svn.mozilla.org/vc/projects/mozilla.org/trunk/security

http://viewvc.svn.mozilla.org/vc/projects/mozilla.org/trunk/projects/security

Comment 6

[Sudheendra]

Attachment: adding new security section to leftmenu.php file , needs to be tested on staging site of mozilla.

Comment 7

[David Boswell]

I just checked in this patch to stage:

http://viewvc.svn.mozilla.org/vc?view=revision&revision=93599

This won't lead to any visible changes until we update the templates in the /security section and call this new nav item.

The links in the nav area also fine for now as placeholders, but we'll want to update them to the correct links at some point.

For instance the Vulnerabilities link is set as:

/projects/#applications

and should be

/security/known-vulnerabilities/

Comment 8

[David Boswell]

Adding a note about nav items for the security center: we should also 'Contribute to Security' link.

Comment 9

[Casey Becking]

Hey David, I would like to take this bug on. It looks like nothing has been committed is that correct?

Comment 10

[David Boswell]

Casey, great.

The only thing that has been committed so far is this patch to the LeftMenu.php file so that there would be some content in that file to reference from the Security pages.

http://viewvc.svn.mozilla.org/vc?view=revision&revision=93599

If you have any other questions about what this bug is trying to achieve or how the different parts of the templating work, let me know.

Comment 11

[Casey Becking]

I have updated all the templates within the security section to contain the new sidebar as well as the -2010 update. Please let me know if you would like a diff file or how you would like me to pass the pages.

Comment 12

[David Boswell]

Casey, that's great.  Could you attach your changes as a patch?  The following page has information about making patches.

https://developer.mozilla.org/En/Creating_a_patch

BTW, in terms of timing, there's a conference this week and we probably won't have much time to look at your patch until next week.

Comment 13

[Casey Becking]

Attachment: Diff file for security section changes as well as left_menu.php

Diff file for security section changes as well as left_menu.php

Comment 14

[David Boswell]

Gordon, would you be able to help Casey by checking in his patch to stage for testing?

Comment 15

[Gordon P. Hemsley [:GPHemsley]]

(In reply to David Boswell from comment #14)
> Gordon, would you be able to help Casey by checking in his patch to stage
> for testing?

Attachment 560362 [details] [diff] committed to stage in r95177 (minus the LeftMenu.php part, which was committed in r93599). Should appear live momentarily.

Comment 16

[Casey Becking]

My Leftbar.php had some updated links, I was still missing two links. (Security Architecture and Authorization)

Comment 17

[Gordon P. Hemsley [:GPHemsley]]

(In reply to Casey Becking from comment #16)
> My Leftbar.php had some updated links, I was still missing two links.
> (Security Architecture and Authorization)

Oh, did I miss it? There were a bunch of merge conflicts I had to deal with when I merged trunk to staging. Would you mind making a new diff (against staging, if possible) that includes those missing changes? (Or, even better, that actually adds the real links instead of the placeholders?)

Thanks!

Comment 18

[Casey Becking]

yeah I can add the links I just need to know what they are, I couldn't find them.

Comment 19

[David Boswell]

Gordon, thanks for checking that in.

Casey, this looks good.  We'll ask dveditz to sign off after we fix up the links.

Here are my suggestions for the links in the nav:

* Security Advisories
http://www-stage.mozilla.org/security/announce/

* Known Vulnerabilities
http://www-stage.mozilla.org/security/known-vulnerabilities/

* Bug Bounty
http://www-stage.mozilla.org/security/bug-bounty.html

* Security Blog
http://blog.mozilla.com/security/

Feel free to suggest other things to add if this is missing anything.

Comment 20

[Casey Becking]

Attachment: LeftMenu.diff with updated links

LEftMenu.php diff file adding links.

Comment 21

[David Boswell]

Casey's latest patch has been commited in r95473.

http://viewvc.svn.mozilla.org/vc?view=revision&revision=95473

Once this shows up on stage, we'll ask dveditz to review and approve.

Comment 22

[David Boswell]

Dan, we've just checked in a patch that replaces the generic side nav that had been used on the Security Center pages with a set of Security-specific links.  Can you review the pages on stage when you have a chance and let us know if you approve and if you'd change or add to any of the nav links?

http://www-stage.mozilla.org/security/

Comment 23

[Daniel Veditz [:dveditz]]

Stage looks good. Back to you since I don't know what else to do here.

Comment 24

[David Boswell]

Gordon, could you check this in to production when you have a chance?

Comment 25

[Gordon P. Hemsley [:GPHemsley]]

(In reply to David Boswell from comment #24)
> Gordon, could you check this in to production when you have a chance?

Merged r93599, r95177, and r95473 to production in r96478. Should appear shortly.

Comment 26

[David Boswell]

Gordon, thanks for checking this in.

Casey, thanks for the patch (and after a couple more patches, we can get you commit access so you can check things in directly if you'd like).

Comment 27

[Kohei Yoshino [:kohei]]

Closing.