You don't assign oldValue, this ain't gonna work ;)
Created attachment 405846 [details] [diff] [review] oops
Comment on attachment 405846 [details] [diff] [review] oops GetTarget only throws when it is passed invalid arguments. We should fix the caller to not do that instead.
(In reply to comment #4) > (From update of attachment 405846 [details] [diff] [review]) > GetTarget only throws when it is passed invalid arguments. We should fix the > caller to not do that instead. invalid in what way? I always thought that GetTarget also throws if "source" resource does not exist for example.
GetTarget only throws if source or property are null, however the error message you're getting isn't from GetTarget throwing, it is xpconnect throwing because source or property are not null or JS objects that it can pretend are nsIRDFResources.
Ubuntu bug: https://bugs.launchpad.net/bugs/441552
Created attachment 407108 [details] [diff] [review] fix type of newVersion property... ok newVersion was just a string while setItemProperty/setProperty requires a nsIRDFResource ... this patch fixes it by using EM_R("newVersion") That said I noticed that setItemProperty assumes a nsIRDFResource as "property", while getItemProperty seems to EM_R "property" all the time. Might be worth looking into making the behaviour more consistent.
Comment on attachment 407108 [details] [diff] [review] fix type of newVersion property... Ubuntu is already using this patch on their 1.9.1 branch, so would like to get this backported.
Comment on attachment 407108 [details] [diff] [review] fix type of newVersion property... a192=beltzner
Comment on attachment 407108 [details] [diff] [review] fix type of newVersion property... Approved for 18.104.22.168 and 22.214.171.124, a=dveditz for release-drivers
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7b12d53eed85 Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in; /cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v <-- nsExtensionManager.js.in new revision: 1.290; previous revision: 1.289 done
The nsExtensionManager.js.in module is gone on trunk. Just marking it as verified fixed.