521848 - (omgreallyapple) Accelerometer on newer MBP have x and y reversed

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Doug Turner (:dougt)]

paul and mark observed that MacBook5,1 have their x and y axis reversed.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Josh Aas]

Comment on attachment 405947 [details] [diff] [review]
patch v.1

>+static char gModelName[64];

Use a macro (MODEL_NAME_LENGTH) for the "64" constant since you use it in two places in the patch. Keep things in sync.

Comment 3

[Josh Aas]

Accelerometer events are broken on model 5,3 too. I need to do this to fix it:

else if (!strcmp(gModelName, "MacBookPro5,3")) {
  xf = ((float)data->y) / normalizeFactor;
  yf = (((float)data->x) / normalizeFactor) * -1;
  zf = (((float)data->z) / normalizeFactor) * -1;
}

Comment 4

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 5

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/ab54c2173373

Leaving open until we get 5,2 data.

Comment 6

[Josh Aas]

Perhaps we can do something more like this project does, maybe even get them to contribute code:

http://unimotion.cvs.sourceforge.net/

Comment 7

[Doug Turner (:dougt)]

emailed author.  waiting for reply.

Comment 8

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2d197320e6d0

Comment 9

[Doug Turner (:dougt)]

might as well close and open a new bug for the 5,2 line of mbps.