If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.
Bug 521848 (omgreallyapple)

Accelerometer on newer MBP have x and y reversed

RESOLVED FIXED

Status

()

Core
Widget: Cocoa
--
major
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

(Blocks: 1 bug)

unspecified
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.58 KB, patch
Josh Aas
: review+
Stuart Parmenter
: approval1.9.2+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
paul and mark observed that MacBook5,1 have their x and y axis reversed.
(Assignee)

Comment 1

8 years ago
Created attachment 405947 [details] [diff] [review]
patch v.1
Assignee: nobody → doug.turner
Attachment #405947 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #405947 - Flags: review? → review?(joshmoz)

Comment 2

8 years ago
Comment on attachment 405947 [details] [diff] [review]
patch v.1

>+static char gModelName[64];

Use a macro (MODEL_NAME_LENGTH) for the "64" constant since you use it in two places in the patch. Keep things in sync.
Attachment #405947 - Flags: review?(joshmoz) → review+

Comment 3

8 years ago
Accelerometer events are broken on model 5,3 too. I need to do this to fix it:

else if (!strcmp(gModelName, "MacBookPro5,3")) {
  xf = ((float)data->y) / normalizeFactor;
  yf = (((float)data->x) / normalizeFactor) * -1;
  zf = (((float)data->z) / normalizeFactor) * -1;
}
(Assignee)

Comment 4

8 years ago
Created attachment 405971 [details] [diff] [review]
patch v.2
Attachment #405947 - Attachment is obsolete: true
Attachment #405971 - Flags: review?(joshmoz)

Updated

8 years ago
Attachment #405971 - Flags: review?(joshmoz) → review+
(Assignee)

Updated

8 years ago
Attachment #405971 - Flags: approval1.9.2?
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/ab54c2173373

Leaving open until we get 5,2 data.

Comment 6

8 years ago
Perhaps we can do something more like this project does, maybe even get them to contribute code:

http://unimotion.cvs.sourceforge.net/
(Assignee)

Comment 7

8 years ago
emailed author.  waiting for reply.

Updated

8 years ago
Alias: omgreallyapple

Updated

8 years ago
Attachment #405971 - Flags: approval1.9.2? → approval1.9.2+
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2d197320e6d0

Updated

8 years ago
status1.9.2: --- → beta1-fixed
(Assignee)

Comment 9

7 years ago
might as well close and open a new bug for the 5,2 line of mbps.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

6 years ago
Blocks: 722665
You need to log in before you can comment on or make changes to this bug.