Closed Bug 521956 Opened 10 years ago Closed 10 years ago

nsUpdateService, nsExtensionManager.js.in and, nsBlocklistService include badCertHandler.js

Categories

(Toolkit :: Application Update, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta2-fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Whiteboard: [ts])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #521452 +++

The file sizes of these three files can be reduced by changing badCertHandler.js into a js module.
No longer depends on: 521452
Attached patch patch rev1Splinter Review
Perhaps rename badCertHandler to CertHandlerUtils.jsm or CertUtils.jsm as well?
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #405991 - Flags: review?(dtownsend)
Comment on attachment 405991 [details] [diff] [review]
patch rev1

Looks good, I think CertUtils.jsm is a better name. I'll file a followup bug to get rid of some of the redundant code that xhr can handle by itself now.
Attachment #405991 - Flags: review?(dtownsend) → review+
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/bcf17cac4398
http://hg.mozilla.org/mozilla-central/rev/861604a73c02
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [ts]
Comment on attachment 405991 [details] [diff] [review]
patch rev1

Drivers, this code used to be included in three separate components and is now a js module and only loaded when used to lessen file size which should help Fennec / WinCE Firefox.
Attachment #405991 - Flags: approval1.9.2?
Blocks: 311965
Blocks: 311968
Attached patch patch for 1.9.2Splinter Review
Updated to use the lazy getters in bug 508850 since that has now landed on 1.9.2
Attachment #406408 - Flags: review+
Attachment #406408 - Flags: approval1.9.2?
Attachment #405991 - Flags: approval1.9.2?
Comment on attachment 406408 [details] [diff] [review]
patch for 1.9.2

a192=beltzner
Attachment #406408 - Flags: approval1.9.2? → approval1.9.2+
You need to log in before you can comment on or make changes to this bug.