521956 - nsUpdateService, nsExtensionManager.js.in and, nsBlocklistService include badCertHandler.js

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

+++ This bug was initially created as a clone of Bug #521452 +++

The file sizes of these three files can be reduced by changing badCertHandler.js into a js module.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Perhaps rename badCertHandler to CertHandlerUtils.jsm or CertUtils.jsm as well?

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 405991 [details] [diff] [review]
patch rev1

Looks good, I think CertUtils.jsm is a better name. I'll file a followup bug to get rid of some of the redundant code that xhr can handle by itself now.

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/bcf17cac4398
http://hg.mozilla.org/mozilla-central/rev/861604a73c02

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 405991 [details] [diff] [review]
patch rev1

Drivers, this code used to be included in three separate components and is now a js module and only loaded when used to lessen file size which should help Fennec / WinCE Firefox.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch for 1.9.2

Updated to use the lazy getters in bug 508850 since that has now landed on 1.9.2

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 406408 [details] [diff] [review]
patch for 1.9.2

a192=beltzner

Comment 7

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.2
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0db55ef9976f
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c031aff70926