522039 - The prompt-service should dismiss the alert/prompt/confirm/... on VK_RETURN / VK_ESCAPE

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

I'm doing a little web application wich uses prompt() to get informations from the user.
So as a user I need to:
 1. click with my finger on the application's item
 2. wait for the prompt
 3. write an answer with the hard keyboard / soft keyboard
 4. try to hit the OK or Cancel button with my finger

Step 3 and 4 should be in the same row.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 406032 [details] [diff] [review]
Patch v0.2

>diff -r 331a2cea3888 chrome/content/prompt/alert.xul
>+  <keyset>
>+    <key keycode="VK_RETURN" command="cmd_ok"/>
>+    <key keycode="VK_ESCAPE" command="cmd_cancel"/>
>+  </keyset>
>+  <commandset>
>+    <command id="cmd_ok" key="VK_RETURN" oncommand="document.getElementById('prompt-alert-dialog').close()"/>
>+    <command id="cmd_cancel" key="VK_ESCAPE" oncommand="document.getElementById('prompt-alert-dialog').close()"/>
>+  </commandset>

I'll remove these two <command key=""/> when I check in

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/e750bff79dc2

Comment 4

[Aakash Desai [:aakashd]]

Vivien, can you verify this is fixed? This might affect future mozmill testscripts for Fennec.

Comment 5

[Dão Gottwald [:dao]]

bugspam