Closed Bug 522039 Opened 10 years ago Closed 10 years ago

The prompt-service should dismiss the alert/prompt/confirm/... on VK_RETURN / VK_ESCAPE

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
I'm doing a little web application wich uses prompt() to get informations from the user.
So as a user I need to:
 1. click with my finger on the application's item
 2. wait for the prompt
 3. write an answer with the hard keyboard / soft keyboard
 4. try to hit the OK or Cancel button with my finger

Step 3 and 4 should be in the same row.
Attached patch Patch v0.2Splinter Review
Attachment #406024 - Attachment is obsolete: true
Attachment #406032 - Flags: review?(mark.finkle)
Comment on attachment 406032 [details] [diff] [review]
Patch v0.2

>diff -r 331a2cea3888 chrome/content/prompt/alert.xul
>+  <keyset>
>+    <key keycode="VK_RETURN" command="cmd_ok"/>
>+    <key keycode="VK_ESCAPE" command="cmd_cancel"/>
>+  </keyset>
>+  <commandset>
>+    <command id="cmd_ok" key="VK_RETURN" oncommand="document.getElementById('prompt-alert-dialog').close()"/>
>+    <command id="cmd_cancel" key="VK_ESCAPE" oncommand="document.getElementById('prompt-alert-dialog').close()"/>
>+  </commandset>

I'll remove these two <command key=""/> when I check in
Attachment #406032 - Flags: review?(mark.finkle) → review-
Attachment #406032 - Flags: review- → review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/e750bff79dc2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Vivien, can you verify this is fixed? This might affect future mozmill testscripts for Fennec.
bugspam
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.