522114 - can only play the first few minutes of a video

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Christopher Blizzard (:blizzard)]

I think that we're not able to play past the end of the media cache.  On the video above we play the first five minutes of the video and then it stops and shows itself at the end of the video.

(The video is 15 minutes long, is about 146MB in size and it stops at about 5 minutes.  I think our default media cache is 50MB?)

Works OK in Firefox 3.5.

Comment 1

[Matthew Gregan [:kinetik]]

Two problems here:

The media cache doesn't seem to be releasing blocks once they're played, so once the cache fills we continuously suspend and resume the stream to allow playback to continue.

When the video ends prematurely, we've just resumed the stream.  We get one OnDataAvailable callback on the stream, then an OnStopRequest which causes the media cache to treat the stream as ended.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix pin count check

Stupid bug made us think we were always pinned.

To test this properly we need support for 'buffered'.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix resuming

We should reopen if the connection closes after a resume, even if it appeared to close normally.

We still end prematurely if the connection is not seekable and we suspend, then the server closes our connection. That's just too bad, there's really no way to handle these scenarios. Fortunately with the pinning bug fixed we won't suspend nearly as much.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in:
http://hg.mozilla.org/mozilla-central/rev/d02342520b16
http://hg.mozilla.org/mozilla-central/rev/9de290615b21

Disabled test_resume because it's failing sometimes:
http://hg.mozilla.org/mozilla-central/rev/50796c65175d

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/efb34f0db626
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/aeb61beac373

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5e9f965502ef