522149 - Add CSS media queries for all features supported in :-moz-system-metric()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[:Felipe Gomes (needinfo for replies!)]

We should build a CSS media query for the touch features. We could use a simple one that just tests for the touch support or not, or more advanced queries for checking capabilities, e.g. number of touch points, type (pen vs finger), etc.

I took a look at the media query spec but couldn't tell from it if the current media features list is a definitive one or if browsers are encouraged to have their own queries. Can we implement it now and then try to move it to the spec, or do we use a moz extension by now?

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We are allowed to add our own -moz values. And yes, we should then propose them as additions to the spec.

Comment 2

[David Baron :dbaron:]

I think the thing to do here is support everything we support as :-moz-system-metric() values as individual media features (much like 'grid').

I can write up a patch for this, unless you've already started.

Comment 3

[David Baron :dbaron:]

I'm working on this.

Comment 4

[David Baron :dbaron:]

Attachment: patch 1: put system metrics in atom list

Comment 5

[David Baron :dbaron:]

Attachment: patch 2: turn mKeywordList into more generic mData so I can reuse it

Comment 6

[David Baron :dbaron:]

Attachment: patch 3: pass media feature to its own value getter so we can share getters

Comment 7

[David Baron :dbaron:]

Attachment: patch 4: implement -moz-prefixed media features for system metrics

Comment 8

[David Baron :dbaron:]

Attachment: patch 5: tests

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 406311 [details] [diff] [review]
patch 2: turn mKeywordList into more generic mData so I can reuse it

I would prefer something like:

union {
  const PRInt32* mKeywordTable;
  nsIAtom * const * mMetric;
} mData;

or something.  Initialization should still work, and the consumer code can be a bit more readable...

r=bzbarsky with that.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 406314 [details] [diff] [review]
patch 4: implement -moz-prefixed media features for system metrics

r=bzbarsky if you add asserts on mValueType in GetSystemMetric.

Comment 11

[David Baron :dbaron:]

(In reply to comment #9)
> or something.  Initialization should still work, and the consumer code can be a
> bit more readable...

It would?  I did what I did on the assumption that it wouldn't; I suppose I'll give it a try.  (Do you happen to know of other code that does this?)

Comment 12

[David Baron :dbaron:]

Luke Wagner explained it to me: brace it, and it will initialize the first member of the union.  (So I'll add a void* for initialization.)

Comment 13

[David Baron :dbaron:]

Revised patches:
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/3a54173d5427/system-metrics-atom-list
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/3a54173d5427/media-feature-data
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/3a54173d5427/media-feature-pass-feature-to-getter
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/3a54173d5427/media-queries-for-system-metrics
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/3a54173d5427/media-queries-system-metrics-tests

Comment 14

[David Baron :dbaron:]

http://hg.mozilla.org/mozilla-central/rev/c96a69f2907f
http://hg.mozilla.org/mozilla-central/rev/e41cdf6f6fec
http://hg.mozilla.org/mozilla-central/rev/ea59ebdadb1a
http://hg.mozilla.org/mozilla-central/rev/0523cf3e62d3
http://hg.mozilla.org/mozilla-central/rev/05a53028f21f

Comment 15

[David Baron :dbaron:]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/dc5983ff33b0
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d49985311a9f
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ae490b884c80
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/90f38ea369f5
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/dc4cdcc26f37

(merged to remove the images-in-buttons metric)

Comment 16

[Eric Shepherd [:sheppy]]

What are the moz-windows-compositor, moz-windows-classic, and moz-maemo-classic queries for exactly? These metrics have not previously been documented, so I have nothing to easily reference.

Also, is there a bug to add a media query for orientation?

The rest of these have been added here:

https://developer.mozilla.org/En/CSS/Media_queries#Mozilla-specific_media_features

Comment 17

[David Baron :dbaron:]

(In reply to comment #16)
> What are the moz-windows-compositor, moz-windows-classic, and moz-maemo-classic
> queries for exactly? These metrics have not previously been documented, so I
> have nothing to easily reference.

Probably the best documentation for them is in:
http://hg.mozilla.org/mozilla-central/annotate/a6273493eab4/widget/public/nsILookAndFeel.h#l238
(and there should be links to bugs if you follow the changeset links in the blame on the left side, too).

> 
> Also, is there a bug to add a media query for orientation?

We already support 'orientation' as defined in http://dev.w3.org/csswg/css3-mediaqueries/#orientation

Comment 18

[Eric Shepherd [:sheppy]]

Duh, I even already had orientation documented. Sheesh.

OK, these are now all documented.

Comment 19

[David Baron :dbaron:]

I also landed an additional comment:
http://hg.mozilla.org/mozilla-central/rev/4f3a789f3c3f