522271 - --browser-chrome Mochitests on Fennec [bookmark popup]

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We need to add tests to browser_bookmark_star.js for the bookmark popup:

* Verify it appears (kinda have this already)
* Verify it dismisses if click off of it
* Verify it dismisses if click on star again
* Verify it dismisses if timeout occurs (2seconds)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch adds a test for the bookmark popup auto-hiding after 2 seconds. The tests already have checks for the popup appearing.

It also:

* fixes the tests for a bad todo
* handles a button rename
* increases robustness by using waitFor in more places (I was getting failures without it)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

Sorry for the review queue spam. This patch is the same as the first but adds the two remaining tests:

* Verify it dismisses if click off of it
* Verify it dismisses if click on star again

all pass!

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 406628 [details] [diff] [review]
patch 2

>diff --git a/chrome/tests/browser_bookmarks_star.js b/chrome/tests/browser_bookmarks_star.js

>+    var handleEvent = function() {

function handleEvent

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with change:
https://hg.mozilla.org/mobile-browser/rev/e6bef4579943