522282 - Toolbar icons - Use the N900 theme or use our own variant

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

N900 ships with several themes and more can be added. We currently have the task switcher, close and back images hard coded. We could try to pull the correct images from the theme itself so we adapt when the theme changes.

Or we could go the route the N900 Maps application uses: Custom images that fit the app theme and not use the current theme.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

We have decided to create our own variant of the task bar icons for Fennec 1.0

Assigning to Madhava until we get a designer to work on it.

Comment 3

[Madhava Enros [:madhava]]

putting some thoughts down about this --

- we don't want them to blend in with fennec too much -- I'm relying on them looking more like the system than our own controls to provide cues about what they're for (i.e. NOT browser controls)
- the forms should remain the same as for the rest of the system, so all we have to work with is the interior spaces (color, gradients)

Comment 4

[Madhava Enros [:madhava]]

Attachment: custom OS button icons

Comment 5

[Madhava Enros [:madhava]]

Attachment: now the same size as the ones they're replacing

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/4fd882c65431

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091201 Firefox/3.6b5pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091201 Firefox/3.7a1pre Fennec/1.0b5