522309 - filter out access points that do not have SSIDs

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect, P2)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

If an access point has an empty SSID, we should consider not reporting it to any network geolocation provider.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 406262 [details] [diff] [review]
patch v.1

Indentation here is all weird. I would prefer:

function filterBlankSSIDs(ap) ap.ssid != ""
function deconstruct(ap) ({
  mac_address: ap.mac,
  ssid: ap.ssid,
  signal_strength: ap.signal
})

request.wifi_towers = accessPoints.filter(filterBlankSSIDs).map(deconstruct);

Comment 2

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/0fe41a905fe6

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Good hygiene, should block on this, I think.

Comment 4

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a8718b7d0bac

Comment 5

[Daniel Veditz [:dveditz]]

Pretty sure you meant 1.9.1 rather than 1.9.0, but if this feature really is in Firefox 3.0 somewhere please renominate for that branch.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 406262 [details] [diff] [review]
patch v.1

Approved for 1.9.1.5, a=dveditz for release-drivers

Comment 7

[Samuel Sidler (old account; do not CC)]

Doug?

Comment 8

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4325d647ddee


QA -- it is easiest to verify this on windows xp, vista, or 7.


1) enable universal permissions:

pref("signed.applets.codebase_principal_support", true)


2) load the following page:

http://people.mozilla.org/~dougt/wifi_access_point_test.html

3) Accept the permission dialogs (there should be at least two)

4) what you will see a list that has entries like:

00-11-52-39-38-c3 MyAccessPoint -62


In a fixed build, you should _never_ see a line that doesn't have a access point name.  For example, if you see something like:

00-11-52-39-38-c3 -62

Then we can't resolve fixed on 1.9.1.*

Comment 9

[Marcia Knous [:marcia]]

Doug: Using  Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b3pre) Gecko/20091112 Namoroka/3.6b3pre GTB6 (.NET CLR 3.5.30729), I see several entries such as:

00-1a-1e-12-70-21 -65

So if Comment 8 applies to 1.9.2 as well, this does not appear to be fixed.

Comment 10

[Doug Turner (:dougt)]

oh, i am sorry.  there should have been more steps for QA.


5) enable wifi geo logging:

pref("geo.wifi.logging.enabled", true)

6) restart browser

7) load http://people.mozilla.org/~dougt/geo.html

8) inspect javascript console.

Any mac address listed w/ an empty access point name should not be listed in the javscript console.

Comment 11

[Marcia Knous [:marcia]]

This looks good following the Steps from Comments 8 and 10. Verified fixed on the 1.9.2 branch using Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b3pre) Gecko/20091112 Namoroka/3.6b3pre GTB6 (.NET CLR 3.5.30729). Adding keyword.

Comment 12

[Al Billings [:abillings - ex-MoCo]]

Marcia, can you verify this on a Windows box in the lab with a nightly 1.9.1 build? I only have VMs and am remote until next week.