Closed Bug 522309 Opened 11 years ago Closed 11 years ago

filter out access points that do not have SSIDs


(Core :: DOM: Geolocation, defect, P2)




Tracking Status
status1.9.2 --- beta1-fixed
blocking1.9.1 --- .6+
status1.9.1 --- .6-fixed


(Reporter: dougt, Assigned: dougt)


(Keywords: privacy, Whiteboard: verified1.9.2)


(1 file)

Attached patch patch v.1Splinter Review
If an access point has an empty SSID, we should consider not reporting it to any network geolocation provider.
Attachment #406262 - Flags: review?(
Comment on attachment 406262 [details] [diff] [review]
patch v.1

Indentation here is all weird. I would prefer:

function filterBlankSSIDs(ap) ap.ssid != ""
function deconstruct(ap) ({
  mac_address: ap.mac,
  ssid: ap.ssid,
  signal_strength: ap.signal

request.wifi_towers = accessPoints.filter(filterBlankSSIDs).map(deconstruct);
Attachment #406262 - Flags: review?( → review+
Closed: 11 years ago
Resolution: --- → FIXED
Flags: blocking1.9.2?
Good hygiene, should block on this, I think.
Flags: blocking1.9.2? → blocking1.9.2+
Keywords: privacy
Priority: -- → P2
Pretty sure you meant 1.9.1 rather than 1.9.0, but if this feature really is in Firefox 3.0 somewhere please renominate for that branch.
blocking1.9.1: --- → .5+
Flags: blocking1.9.0.16?
Attachment #406262 - Flags: approval1.9.1.5?
Attachment #406262 - Flags: approval1.9.1.5? → approval1.9.1.5+
Comment on attachment 406262 [details] [diff] [review]
patch v.1

Approved for, a=dveditz for release-drivers

QA -- it is easiest to verify this on windows xp, vista, or 7.

1) enable universal permissions:

pref("signed.applets.codebase_principal_support", true)

2) load the following page:

3) Accept the permission dialogs (there should be at least two)

4) what you will see a list that has entries like:

00-11-52-39-38-c3 MyAccessPoint -62

In a fixed build, you should _never_ see a line that doesn't have a access point name.  For example, if you see something like:

00-11-52-39-38-c3 -62

Then we can't resolve fixed on 1.9.1.*
Doug: Using  Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b3pre) Gecko/20091112 Namoroka/3.6b3pre GTB6 (.NET CLR 3.5.30729), I see several entries such as:

00-1a-1e-12-70-21 -65

So if Comment 8 applies to 1.9.2 as well, this does not appear to be fixed.
oh, i am sorry.  there should have been more steps for QA.

5) enable wifi geo logging:

pref("geo.wifi.logging.enabled", true)

6) restart browser

7) load

8) inspect javascript console.

Any mac address listed w/ an empty access point name should not be listed in the javscript console.
This looks good following the Steps from Comments 8 and 10. Verified fixed on the 1.9.2 branch using Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b3pre) Gecko/20091112 Namoroka/3.6b3pre GTB6 (.NET CLR 3.5.30729). Adding keyword.
Whiteboard: verified1.9.2
Marcia, can you verify this on a Windows box in the lab with a nightly 1.9.1 build? I only have VMs and am remote until next week.
You need to log in before you can comment on or make changes to this bug.