522343 - With no lightweight themes installed, previewing a persona will bounce screen up a pixel

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Tony Chung [:tchung]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1pre) Gecko/20091014 Namoroka/3.6b1pre

With a new profile, previewing a personas theme on Getpersonas.com, will make the browser jump up a pixel.  This applies for both the personas extension, or using a 3.6 persona uplift build.   But since it repros with the extension, i'm filing it in this category

Repro:
1) open a new profile
2) install personas extension
3) go to URL, mousehover the personas preview image
4) notice the entire browser screen space "jumps" up a pixel.  moving off the image will drop back down to normal

This only seems to happen with a new profile.

Expected:
- no "jumping" of the screen when previewing a theme

Actual:
- jumps up a pixel.

Comment 1

[Marcia Knous [:marcia]]

Once I install a personal by selecting the wear it now button, then the previews are fine. So the bug really is jumps when you haven't previously installed a persona. I am using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1) Gecko/20091019 Firefox/3.6b1 but this happens on other platform as well.

Comment 2

[Jose E. Bolanos]

When no lightweight themes/personas are installed, the Bookmarks Toolbar has a top and bottom border of 1px each. When a persona is previewed or worn, the top and bottom borders change to zero.

The CSS style rules which turns them to zero are:
#PersonalToolbar:-moz-lwtheme
#navbar:-moz-lwtheme
and so on.

I suspect the status bar also suffers from the same problem.

How should we proceed? Should we make the change in the Personas add-on to keep the 1px top and bottom margin on the affected elements?

Comment 3

[Johnathan Nightingale [:johnath]]

Removing the borders is deliberate, to make the persona seamless, but I agree this is more jarring than we'd like the first experience to be.

I think this is something we should fix in the in-product support, but since this bug is filed against the addon, which might also want to fix it (e.g. for pre-FF36 users) we might need to clone the bug, to track the work separately?

Dao, do you have an opinion on the best way to cure the jumpiness, here?

Comment 4

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #3)
> Removing the borders is deliberate, to make the persona seamless, but I agree
> this is more jarring than we'd like the first experience to be.

Note: the extension has been removing borders for a long time to make personas seamless, but we've carefully crafted CSS rules to ensure that it doesn't cause a change to the height of the chrome.  The rules tend to be brittle, however, and break when the default theme changes.

The techniques used vary by OS and the element being affected (in particular, whether or not the element's borders are being determined by a -moz-appearance rule on the OS).  Here's what the extension currently does for the bookmarks toolbar on Mac:

  #main-window[persona] #PersonalToolbar {
    /* The personal (a.k.a. bookmarks) toolbar doesn't have a -moz-appearance,
     * but it does have top and bottom borders, which we simply hide by setting
     * their color to transparent.  Note that the bottom border is set via both
     * border-bottom-color and -moz-border-bottom-colors in the default theme.
     * The latter appears to override the former, so we probably only need to set
     * -moz-border-bottom-colors to transparent, but we set them both anyway
     * just in case.
     */
    border-top-color: transparent;
    border-bottom-color: transparent;
    -moz-border-bottom-colors: transparent;
  }

<http://hg.mozilla.org/labs/personas/file/68dd3b327e9f/client/skin/mac3.1/personas.css#l66>

Comment 5

[Juan Manuel Rodriguez Alvardo]

Attachment: proposed patch for preview bounce

This patch overwrites the styles set by Firefox 3.6 in order to prevent persona preview bounce issue on mac.

PersonalToolbar style overwrite solves the most visible part of the issue. However, the statusbar and findbar styles presented a similar problem, but they were harder to see as the bar is smaller and not as prominent as the top section of the browser.

This patch addresses all the "bounces" in those three elements.

Comment 6

[Juan Manuel Rodriguez Alvardo]

Attachment: proposed patch for preview bounce V2

The previous patch was throwing errors when you tried to apply it.

This one has problems finding the personas.css file under the mac3.1 skin folder if you use "hg import -p2 /path/to/the/file". It works just fine if you apply it with the next command:

patch -p2 </path/to/the/file 

For these commands I'm assuming you are inside the "client" folder of the sources.

Comment 7

[Jose E. Bolanos]

Comment on attachment 413091 [details] [diff] [review]
proposed patch for preview bounce V2

Looks good. The jumping goes away in Mac.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

I'm unable to reproduce this problem on the latest Firefox 3.6 nightly build (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2b4pre) Gecko/20091118 Namoroka/3.6b4pre).

I do see the height of the status bar decrease by what looks like one pixel when a persona is previewed, and if the find bar is visible, it looks like the combined height of the status and find bars decreases by two pixels.  However, the height of the chrome at the top of the page doesn't change.

(In reply to comment #2)
> When no lightweight themes/personas are installed, the Bookmarks Toolbar has
> a top and bottom border of 1px each. When a persona is previewed or worn, the
> top and bottom borders change to zero.
> 
> The CSS style rules which turns them to zero are:
> #PersonalToolbar:-moz-lwtheme
> #navbar:-moz-lwtheme
> and so on.

That might have been true in early versions of lightweight themes, but it seems to have changed per changeset http://hg.mozilla.org/mozilla-central/rev/12ae893c4bd7.

In any case, a bug like this that exists in Firefox without Personas installed is a Firefox bug, not a Personas bug, and should be fixed in Firefox, not Personas.  Only if the problem continues to exist with the extension after the Firefox bug is fixed does it make sense to include a fix in the extension.

Thus, unless others can reproduce on the latest nightly, this should be resolved WORKSFORME.  I have filed Firefox bug 529767 on the status/find bar issue.

Comment 9

[Tony Chung [:tchung]]

Still repros for me on 1.9.2 nightlies.  Its not just mac, its also windows.   both the header and the footer is shifting up and down a pixel when previewing the theme.  

See screencast: http://screencast.com/t/MDEzYWNjM2M

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b4pre) Gecko/20091118 Namoroka/3.6b4pre

This is without the personas extension, so i'm going to move it to firefox > General.  Dao, can you take a look?

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Tony: do you still see this on Mac, or do you only see it on Windows now?  These kinds of bugs (and their fixes) tend to be OS-specific, so I just want to make sure we identify exactly which OSes are (still) experiencing the behavior and what behavior they're experiencing (i.e. which toolbars change size and by how many pixels).

Comment 11

[Suneel]

We spoke to Johnath about this during the last compatibility check in and agreed that next steps would be to assign this over to the Firefox team to explore. We also agreed that this likely would not be a blocker. 

Assigning to Johnath and removing the dependency on this for Personas 1.5 release.

Comment 12

[Tony Chung [:tchung]]

(In reply to comment #10)
> Tony: do you still see this on Mac, or do you only see it on Windows now? 
> These kinds of bugs (and their fixes) tend to be OS-specific, so I just want to
> make sure we identify exactly which OSes are (still) experiencing the behavior
> and what behavior they're experiencing (i.e. which toolbars change size and by
> how many pixels).

Marcia saw it on mac, i saw it on windows.  Thats why i marked it ALL platform.  anyway, i think its better sent to Firefox > General

Comment 13

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 413091 [details] [diff] [review]
proposed patch for preview bounce V2

r- per discussion that this should be fixed in Firefox rather than the Personas extension.

Comment 14

[(no longer active)]

Attachment: Patch (v1)

This patch only applies to 1.9.2.  The code which causes this bug has been removed from the trunk as part of bug 347930.

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 441154 [details] [diff] [review]
Patch (v1)

This only fixes it for Vista and 7, which probably don't need the "uxtheme border drawing fix/hack" in the first place...

Comment 16

[(no longer active)]

(In reply to comment #15)
> (From update of attachment 441154 [details] [diff] [review])
> This only fixes it for Vista and 7, which probably don't need the "uxtheme
> border drawing fix/hack" in the first place...

Hmm, I'm not sure how to interpret this!  :-)  What do I need to do in order to fix this properly?

Comment 17

[Dão Gottwald [:dao]]

You could check whether the "uxtheme border drawing fix/hack" that your patch touches needs to be applied on Windows Vista and 7 at all. If it's not needed, make sure it's not applied.

Comment 18

[(no longer active)]

(In reply to comment #17)
> You could check whether the "uxtheme border drawing fix/hack" that your patch
> touches needs to be applied on Windows Vista and 7 at all. If it's not needed,
> make sure it's not applied.

Hmm, well, I have little idea on what that is trying to fix...

Comment 19

[Dão Gottwald [:dao]]

(In reply to Ehsan Akhgari [:ehsan] from comment #14)
> Created attachment 441154 [details] [diff] [review]
> Patch (v1)
> 
> This patch only applies to 1.9.2.  The code which causes this bug has been
> removed from the trunk as part of bug 347930.

marking WONTFIX for 1.9.2.