522365 - Code run on closing compose window runs into exception due to missing headers-box element

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Susanne Jaeger reported in the German MailNews newsgroup that in MsgComposeCommands.js line 221 document.getElementById("headers-box") returns null.  That element exists in TB but not SM. Consequently the code following that line is not executed.

@Mnyromyr: What's the correct way to fix this? Remove the line or add the element?

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: remove line

The element was removed in bug 509209:
<http://hg.mozilla.org/comm-central/rev/00f6b1b884fc>

Comment 2

[[e-mail]]

Comment on attachment 406333 [details] [diff] [review]
remove line

It wasn't removed, it was renamed, wasn't it?

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Attachment: change id

(In reply to comment #2)
> (From update of attachment 406333 [details] [diff] [review])
> It wasn't removed, it was renamed, wasn't it?

You're right, changed ID. I could have used getMailToolbox() but kept the style of the following lines. Requesting both r+sr from you to try and get this in for 2.0 still.

Comment 4

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/452958079a37