Closed Bug 522365 Opened 11 years ago Closed 11 years ago

Code run on closing compose window runs into exception due to missing headers-box element

Categories

(SeaMonkey :: MailNews: Composition, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Details

(Keywords: fixed-seamonkey2.0)

Attachments

(1 file, 1 obsolete file)

Susanne Jaeger reported in the German MailNews newsgroup that in MsgComposeCommands.js line 221 document.getElementById("headers-box") returns null.  That element exists in TB but not SM. Consequently the code following that line is not executed.

@Mnyromyr: What's the correct way to fix this? Remove the line or add the element?
Attached patch remove line (obsolete) — Splinter Review
The element was removed in bug 509209:
<http://hg.mozilla.org/comm-central/rev/00f6b1b884fc>
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #406333 - Flags: superreview?(neil)
Attachment #406333 - Flags: review?(mnyromyr)
Attachment #406333 - Flags: approval-seamonkey2.0?
Comment on attachment 406333 [details] [diff] [review]
remove line

It wasn't removed, it was renamed, wasn't it?
Attachment #406333 - Flags: superreview?(neil) → superreview-
Attached patch change idSplinter Review
(In reply to comment #2)
> (From update of attachment 406333 [details] [diff] [review])
> It wasn't removed, it was renamed, wasn't it?

You're right, changed ID. I could have used getMailToolbox() but kept the style of the following lines. Requesting both r+sr from you to try and get this in for 2.0 still.
Attachment #406333 - Attachment is obsolete: true
Attachment #406337 - Flags: superreview?(neil)
Attachment #406337 - Flags: review?(neil)
Attachment #406337 - Flags: approval-seamonkey2.0?
Attachment #406333 - Flags: review?(mnyromyr)
Attachment #406333 - Flags: approval-seamonkey2.0?
Attachment #406337 - Flags: superreview?(neil)
Attachment #406337 - Flags: superreview+
Attachment #406337 - Flags: review?(neil)
Attachment #406337 - Flags: review+
Attachment #406337 - Flags: approval-seamonkey2.0? → approval-seamonkey2.0+
Pushed as http://hg.mozilla.org/comm-central/rev/452958079a37
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
Target Milestone: seamonkey2.1a1 → seamonkey2.0
You need to log in before you can comment on or make changes to this bug.