522404 - Cannot create components for multiple products in a row in one script

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P1)

Description

[Max Kanat-Alexander]

Attachment: v1

When creating or updating a product, all cached data about products in the current Bugzilla->user object should be removed. (Otherwise, you can't really create components for two products in a row in the same script, because selectable_products doesn't know that the second product exists, and you get an error.)

Comment 1

[Max Kanat-Alexander]

This is more of a bug, and actually, the above patch doesn't seem to fix it yet. I'll investigate.

Comment 2

[Max Kanat-Alexander]

Attachment: v2

Okay, the problem was that anything could have called get_selectable_products in between the first time we created a product and the second time we're trying to create a product. In my case, it was Bugzilla::Component->create calling it. There's no way to know what's going to call it. The only truly reliable thing to do is to clear the cache immediately after inserting a product into the database, which I do here, and which works.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 406376 [details] [diff] [review]
v2

I have tested this patch and all works as described when creating new product and new component using a test script I wrote. Also normal activities work using the product admin UI. r=dkl

Comment 4

[Max Kanat-Alexander]

Thanks, dkl! :-)

Comment 5

[Max Kanat-Alexander]

Checking in Bugzilla/Product.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Product.pm,v  <--  Product.pm
new revision: 1.40; previous revision: 1.39
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.193; previous revision: 1.192
done