Add a pref for jump list content refresh time

RESOLVED FIXED

Status

()

Firefox
Shell Integration
--
enhancement
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Currently our jump lists refresh at the following times: start, shutdown, and while running, every two minutes. Some users have requested that the running refresh time be moved to a pref. The value is currently hardcoded in the jsm -

http://mxr.mozilla.org/mozilla-central/source/browser/components/wintaskbar/WindowsJumpLists.jsm#48

Move this to taskbar prefs and set the default to 2 minutes.
(Assignee)

Comment 1

8 years ago
Created attachment 446234 [details] [diff] [review]
patch v.1

I switched to 30 seconds for better refresh as well.
Attachment #446234 - Flags: review?(dao)
Comment on attachment 446234 [details] [diff] [review]
patch v.1

Is the rebuilding so cheap that doing it more often is a no-brainer? Was two minutes really a bad choice for the default behavior, i.e. are there concrete drawbacks for real world usage?
Attachment #446234 - Flags: review?(dao) → review+
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> (From update of attachment 446234 [details] [diff] [review])
> Is the rebuilding so cheap that doing it more often is a no-brainer? Was two
> minutes really a bad choice for the default behavior, i.e. are there concrete
> drawbacks for real world usage?

I don't believe there's a big perf hit to this. Over time people have complained about the delay, so now that we have a pref, I think it's safe to move it up to 30 seconds.
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/35e53877db8f
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.