522481 - Add a pref for jump list content refresh time

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement)

Description

[Jim Mathies [:jimm]]

Currently our jump lists refresh at the following times: start, shutdown, and while running, every two minutes. Some users have requested that the running refresh time be moved to a pref. The value is currently hardcoded in the jsm -

http://mxr.mozilla.org/mozilla-central/source/browser/components/wintaskbar/WindowsJumpLists.jsm#48

Move this to taskbar prefs and set the default to 2 minutes.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch v.1

I switched to 30 seconds for better refresh as well.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 446234 [details] [diff] [review]
patch v.1

Is the rebuilding so cheap that doing it more often is a no-brainer? Was two minutes really a bad choice for the default behavior, i.e. are there concrete drawbacks for real world usage?

Comment 3

[Jim Mathies [:jimm]]

(In reply to comment #2)
> (From update of attachment 446234 [details] [diff] [review])
> Is the rebuilding so cheap that doing it more often is a no-brainer? Was two
> minutes really a bad choice for the default behavior, i.e. are there concrete
> drawbacks for real world usage?

I don't believe there's a big perf hit to this. Over time people have complained about the delay, so now that we have a pref, I think it's safe to move it up to 30 seconds.

Comment 4

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/35e53877db8f