522502 - Move NS_SVG_OFFSCREEN_MAX_DIMENSION into gfx

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

It seems to me that the gfx code should be the place to offer clamping of surface sizes in addition to gfxASurface::CheckSurfaceSize(). Having the SVG code use NS_SVG_OFFSCREEN_MAX_DIMENSION makes it likely that as new knowledge is added to CheckSurfaceSize for different devices the SVG code will not stay in sync.

We want to limit the total number of bytes allocated, but we also want to put a cap on width/height. It's not clear to me at this point what type of clamping we want. for same use cases it seems like it would be desirable to reduce the width and height proportionally in order for reduce quality equally in both dimensions (e.g. filter regions?). In others we may just want to clamp one of the dimensions.

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 522502 - replace NS_SVG_OFFSCREEN_MAX_DIMENSION by kReasonableSurfaceSize r=emilio

Comment 2

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=fd7252227d70d99d50eebf270b2084a688e6a995

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/32d0446aec8a
https://hg.mozilla.org/integration/autoland/rev/94065afe9abf
replace NS_SVG_OFFSCREEN_MAX_DIMENSION by kReasonableSurfaceSize r=emilio

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/94065afe9abf