522515 - "ASSERTION: null url in @font-face rule" with <base href="javascript:3">

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: null url in @font-face rule: 'face->mURI', file /Users/jruderman/central/layout/base/nsPresContext.cpp, line 1737

Comment 1

[Jesse Ruderman]

Attachment: testcase 2

Triggers the assertion above, plus:

###!!! ASSERTION: null font uri: 'aFontFaceSrc->mURI', file /Users/jruderman/central/layout/style/nsFontFaceLoader.cpp, line 233

Comment 2

[Jesse Ruderman]

Now that the patch in bug 633299 has landed, the first assertion is also in layout/style/nsFontFaceLoader.cpp.

Comment 3

[Jesse Ruderman]

Attachment: testcase 3 (crashes)

Comment 4

[John Daggett (:jtd)]

Attachment: patch, omit null urls from userfont src array

Simply omit null URL's from userfont src array.  Still need to support other src lists items:

  @font-face {
    family: test;
    src: local(mytest), url(..funky..), url(..normal..);
  }

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 802046 [details] [diff] [review]
patch, omit null urls from userfont src array

r=dbaron, though I'd probably skip the "last" variable and just put that expression inside the () of RemoveElementAt.

Comment 6

[John Daggett (:jtd)]

Pushed to inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a838a676e7c

Comment 7

[Phil Ringnalda (:philor)]

And https://hg.mozilla.org/integration/mozilla-inbound/rev/f9e8e8ce552c since a couple of crashtests were expecting to get stuck with this assertion, and were surprised when they no longer hit it.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a838a676e7c
https://hg.mozilla.org/mozilla-central/rev/f9e8e8ce552c