Closed Bug 522682 Opened 14 years ago Closed 14 years ago
backport Breakpad issue 323 - OS X exception handler / minidump generator should set exception address correctly for EXC
_BAD _ACCESS to branches
You can see the patch here: http://code.google.com/p/google-breakpad/source/detail?r=350# We picked this up on trunk as part of a Breakpad sync in bug 510920, but that feels like way too much to take on a branch. However, this patch is pretty small and localized, and I'd feel safe taking it on a branch. It makes crash reports a lot more useful in these circumstances. I'll put together a 1.9.2 patch for it.
The patch applied cleanly to branch, except for changes to some files that aren't present on branch that we don't actually use in Mozilla anyway (Breakpad added a mac framework that we're not using, and I had to patch some things there). This is a diff against 1.9.2. I'm not sure on procedure here, since this same change already landed on trunk, and has review upstream from a Breakpad peer. Do I need review again? Just approval?
Comment on attachment 406666 [details] [diff] [review] branch patch Well, better to set the flag than not. See the previous comment for an explanation.
Attachment #406666 - Flags: approval1.9.2?
Pushed to 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/28adff5e9307 I think we could take this on 1.9.1 as well, if it applies cleanly then it's probably fine.
Comment on attachment 406666 [details] [diff] [review] branch patch We should take this on 1.9.1. It gives us useful extra data in crash reports. It's a pretty small patch and has been on trunk and 1.9.2 without any known problems for a while.
Attachment #406666 - Flags: approval220.127.116.11?
Comment on attachment 406666 [details] [diff] [review] branch patch Really too late for 18.104.22.168 if it's not a blocker. We'll have to pick this up in 22.214.171.124.
Attachment #406666 - Flags: approval126.96.36.199? → approval188.8.131.52?
That's fine, just forgot to request approval and wanted it on the radar.
Comment on attachment 406666 [details] [diff] [review] branch patch Approved for 184.108.40.206, a=dveditz for release-drivers
Attachment #406666 - Flags: approval220.127.116.11? → approval18.104.22.168+
Pushed to 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/54fc8007354d You can verify this fix by installing "Crash Me Now Advanced", then using Tools -> Crash Me! -> Null pointer deref!, submitting the report, then visiting your crash report and ensuring that the "Crash Address" field is "0x0". Note that this bug is for OS X only. http://ted.mielczarek.org/code/mozilla/crashme-advanced.xpi
You need to log in before you can comment on or make changes to this bug.