backport Breakpad issue 323 - OS X exception handler / minidump generator should set exception address correctly for EXC_BAD_ACCESS to branches

RESOLVED FIXED

Status

()

Toolkit
Breakpad Integration
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Trunk
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(status1.9.2 beta2-fixed, status1.9.1 .8-fixed)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
You can see the patch here:
http://code.google.com/p/google-breakpad/source/detail?r=350#

We picked this up on trunk as part of a Breakpad sync in bug 510920, but that feels like way too much to take on a branch. However, this patch is pretty small and localized, and I'd feel safe taking it on a branch. It makes crash reports a lot more useful in these circumstances.

I'll put together a 1.9.2 patch for it.
(Assignee)

Comment 1

8 years ago
Created attachment 406666 [details] [diff] [review]
branch patch

The patch applied cleanly to branch, except for changes to some files that aren't present on branch that we don't actually use in Mozilla anyway (Breakpad added a mac framework that we're not using, and I had to patch some things there).

This is a diff against 1.9.2. I'm not sure on procedure here, since this same change already landed on trunk, and has review upstream from a Breakpad peer. Do I need review again? Just approval?
(Assignee)

Comment 2

8 years ago
Comment on attachment 406666 [details] [diff] [review]
branch patch

Well, better to set the flag than not. See the previous comment for an explanation.
Attachment #406666 - Flags: approval1.9.2?

Updated

8 years ago
Attachment #406666 - Flags: approval1.9.2? → approval1.9.2+
(Assignee)

Comment 3

8 years ago
Pushed to 1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/28adff5e9307

I think we could take this on 1.9.1 as well, if it applies cleanly then it's probably fine.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
status1.9.1: --- → ?
status1.9.2: --- → final-fixed
Resolution: --- → FIXED
(Assignee)

Comment 4

8 years ago
Comment on attachment 406666 [details] [diff] [review]
branch patch

We should take this on 1.9.1. It gives us useful extra data in crash reports. It's a pretty small patch and has been on trunk and 1.9.2 without any known problems for a while.
Attachment #406666 - Flags: approval1.9.1.6?
Comment on attachment 406666 [details] [diff] [review]
branch patch

Really too late for 1.9.1.6 if it's not a blocker. We'll have to pick this up in 1.9.1.7.
Attachment #406666 - Flags: approval1.9.1.6? → approval1.9.1.7?
(Assignee)

Comment 6

8 years ago
That's fine, just forgot to request approval and wanted it on the radar.
Comment on attachment 406666 [details] [diff] [review]
branch patch

Approved for 1.9.1.8, a=dveditz for release-drivers
Attachment #406666 - Flags: approval1.9.1.8? → approval1.9.1.8+
(Assignee)

Comment 8

7 years ago
Pushed to 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/54fc8007354d

You can verify this fix by installing "Crash Me Now Advanced", then using Tools -> Crash Me! -> Null pointer deref!, submitting the report, then visiting your crash report and ensuring that the "Crash Address" field is "0x0". Note that this bug is for OS X only.

http://ted.mielczarek.org/code/mozilla/crashme-advanced.xpi
status1.9.1: ? → .8-fixed
Blocks: 416754
Blocks: 443738
Blocks: 494671
You need to log in before you can comment on or make changes to this bug.