522713 - Port |Bug 448602 - Have a way to enumerate event listeners| to comm-central (apps)

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1-SM) Just package it [Checkin: See comment 6+14]

"approval-seamonkey2.0=?":
no risk, for 'default' hg branch only.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-TB) Just package it, Improve sort order [Checkin: See comment 13]

Looking for "approval-thunderbird3=?" too:
no risk, m-c only.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1-SB) Just package it, Improve sort order [Checkin: See comment 8+14 & 11]

Comment 4

[Robert Kaiser]

Comment on attachment 406698 [details] [diff] [review]
(Av1-SM) Just package it
[Checkin: See comment 6+14]

A definite no for the 2.0 relbranch, setting request to 2.0.1 instead, which is current 1.9.1-based dev version.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> (From update of attachment 406698 [details] [diff] [review])
> setting request to 2.0.1 instead, which is current 1.9.1-based dev version.

Agreed, that's what I meant: I just didn't know if *2.0.1 applied yet.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 406698 [details] [diff] [review]
(Av1-SM) Just package it
[Checkin: See comment 6+14]


http://hg.mozilla.org/comm-central/rev/74e007ed380f

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 406702 [details] [diff] [review]
(Cv1-SB) Just package it, Improve sort order
[Checkin: See comment 8+14 & 11]

How can we make use of this? Is there some sort of dev doc for this?

For calendar, please push on both comm-central and comm-1.9.1

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 406702 [details] [diff] [review]
(Cv1-SB) Just package it, Improve sort order
[Checkin: See comment 8+14 & 11]


http://hg.mozilla.org/comm-central/rev/13f9b3618d2f
without the "#ifndef MOZILLA_1_9_1_BRANCH".

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #7)
> How can we make use of this? Is there some sort of dev doc for this?

Bug 448602 (still) has 'dev-doc-needed' flag...

Comment 10

[Martin Schröder [:mschroeder]]

(In reply to comment #8)
> (From update of attachment 406702 [details] [diff] [review])
> 
> http://hg.mozilla.org/comm-central/rev/13f9b3618d2f
> without the "#ifndef MOZILLA_1_9_1_BRANCH".

According to comment#7 this patch should have been pushed to comm-1.9.1, too!

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 406702 [details] [diff] [review]
(Cv1-SB) Just package it, Improve sort order
[Checkin: See comment 8+14 & 11]


http://hg.mozilla.org/releases/comm-1.9.1/rev/f12bda2a09d3
(Cv1-SB-191) Improve sort order. [Only]

(In reply to comment #10)
> According to comment#7 this patch should have been pushed to comm-1.9.1, too!

s/should have/still needs/, please!
I was waiting to land another patch of mine at the same time, but that may eventually not happen for a while...

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 406701 [details] [diff] [review]
(Bv1-TB) Just package it, Improve sort order
[Checkin: See comment 13]

> #ifndef MOZILLA_1_9_1_BRANCH
>+#ifndef MOZILLA_1_9_2_BRANCH
> bin\components\content_canvas.xpt
>+bin\components\content_events.xpt
>+#endif
> #endif

Just drop the MOZILLA_1_9_1_BRANCH ifndef now please. r=Standard8 with that fixed.

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 406701 [details] [diff] [review]
(Bv1-TB) Just package it, Improve sort order
[Checkin: See comment 13]


http://hg.mozilla.org/comm-central/rev/6134122abbcd
Bv1-TB, with comment 12 suggestion(s),
and enable it on m-1.9.2 too now.

Comment 14

[Serge Gautherie (:sgautherie)]

http://hg.mozilla.org/comm-central/rev/2f4046f9f31b
(Dv1-SB-SM) Needed on m-1.9.2 too now.