52279 - [MF][FIX]Dead code in nsWindow.cpp/nsWindow.h

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[Mike Kaply [:mkaply]]

The function IsScrollbar starting at:

http://lxr.mozilla.org/seamonkey/source/widget/src/windows/nsWindow.cpp#730

Is dead code.

Comment 1

[Peter Trudelle]

looks like that is kmcclusk's, reassigning.

Comment 2

[Mike Kaply [:mkaply]]

Also PasswordFieldEnter and PasswordFieldExit in windows\nsWindow.cpp.

And what's the deal with PasswordFieldInit? It is in nsIKBStateControl.h but no 
platform seems to do anything with it.

Comment 3

[Kevin McCluskey (gone)]

This bug has been marked "future" because the original netscape engineer working
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug,or if it blocks your work in some way
-- please attach your concern to the bug for reconsideration.

Comment 4

[Kevin McCluskey (gone)]

Rod, can this code be removed?

Comment 5

[rods (gone)]

Frank, is there any need for PasswordFieldInit() method in nsIKBStateControl.h 
or for any platform? It doesn't seem to be used anymore.

Comment 6

[rods (gone)]

Attachment: patch

Comment 7

[rods (gone)]

Note: The patch I just included also contains a fix for nsDataObj.cpp, I am 
removing a printf.

I just talked to ftang and he approved the removal of the method 
"PasswordFieldInit" from the interface.

Comment 8

[Kevin McCluskey (gone)]

patch looks good.
r=[e-mail]

Comment 9

[David Hyatt]

sr=hyatt

Comment 10

[rods (gone)]

fixed

Comment 11

[John Morrison]

verified on the checkin.