Don't notify during startup until all engines are loaded

RESOLVED FIXED in Firefox 3.7a2

Status

()

Firefox
Search
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: rflint, Assigned: rflint)

Tracking

({perf})

Trunk
Firefox 3.7a2
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ts])

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 406834 [details] [diff] [review]
Patch
Whiteboard: [ts]
Created attachment 428863 [details] [diff] [review]
Patch
Attachment #406834 - Attachment is obsolete: true
Attachment #428863 - Flags: review?(gavin.sharp)
Comment on attachment 428863 [details] [diff] [review]
Patch

Given that the search bar only adds the observer after initializing the search service, this doesn't have much of an affect in practice, right? Apart from the calls to notifyObservers, I guess, but with no observers that's pretty cheap :)
Attachment #428863 - Flags: review?(gavin.sharp) → review+
Yeah, it's pretty minimal but was enough to make it visible with dtrace, iirc!

http://hg.mozilla.org/mozilla-central/rev/2858cd90d03c
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a2
This caused most of the browser chrome search tests to timeout - backed out: http://hg.mozilla.org/mozilla-central/rev/59f6be377829
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
derp. http://hg.mozilla.org/mozilla-central/file/2858cd90d03c/toolkit/components/search/nsSearchService.js#l2635
Round 2: Fight!

http://hg.mozilla.org/mozilla-central/rev/241ac7137650
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.