Created attachment 406834 [details] [diff] [review]
Created attachment 428863 [details] [diff] [review]
Comment on attachment 428863 [details] [diff] [review]
Given that the search bar only adds the observer after initializing the search service, this doesn't have much of an affect in practice, right? Apart from the calls to notifyObservers, I guess, but with no observers that's pretty cheap :)
Yeah, it's pretty minimal but was enough to make it visible with dtrace, iirc!
This caused most of the browser chrome search tests to timeout - backed out: http://hg.mozilla.org/mozilla-central/rev/59f6be377829
Round 2: Fight!