Closed Bug 522842 Opened 11 years ago Closed 11 years ago

Don't notify during startup until all engines are loaded

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.7a2

People

(Reporter: rflint, Assigned: rflint)

Details

(Keywords: perf, Whiteboard: [ts])

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
No description provided.
Whiteboard: [ts]
Attached patch PatchSplinter Review
Attachment #406834 - Attachment is obsolete: true
Attachment #428863 - Flags: review?(gavin.sharp)
Comment on attachment 428863 [details] [diff] [review]
Patch

Given that the search bar only adds the observer after initializing the search service, this doesn't have much of an affect in practice, right? Apart from the calls to notifyObservers, I guess, but with no observers that's pretty cheap :)
Attachment #428863 - Flags: review?(gavin.sharp) → review+
Yeah, it's pretty minimal but was enough to make it visible with dtrace, iirc!

http://hg.mozilla.org/mozilla-central/rev/2858cd90d03c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a2
This caused most of the browser chrome search tests to timeout - backed out: http://hg.mozilla.org/mozilla-central/rev/59f6be377829
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Round 2: Fight!

http://hg.mozilla.org/mozilla-central/rev/241ac7137650
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.