523089 - [*|attr] selector doesn't round-trip correctly

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

In particular, it becomes [attr], which is the same thing as [|attr], since the default namespace doesn't apply to attribute selectors.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 407227 [details] [diff] [review]
Fix

>+          NS_ASSERTION(prefixAtom,
>+                       "How did we end up with a namespace if the prefix "
>+                       "is unknown?");

Maybe worth commenting that a non-none namespace on attributes can't have come from the default, since the default doesn't apply?

>diff --git a/layout/style/test/test_namespace_rule.html b/layout/style/test/test_namespace_rule.html

Did you test that some of the serialize-and-rematch tests failed without the patch?  (Did any others fail without it?)

r=dbaron

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Did you test that some of the serialize-and-rematch tests failed without the
> patch? 

Yes, precisely.  The two [*|foo] tests failed serialize-and-rematch.

> (Did any others fail without it?)

No.

Will add the comment.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/6af13824b513 with the comment added.