Closed Bug 523127 Opened 13 years ago Closed 13 years ago

Firefox can't list directories on Sysax FTP server

Categories

(Core :: Networking: FTP, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b1

People

(Reporter: michal, Assigned: michal)

References

Details

Attachments

(1 file)

The problem is similar to bug #214405. It is possible to retrieve directory using RETR from Sysax server. Example of the dump:

220- Sysax Multi Server Service (Version 4)
220
USER michal
331 User name okay, need password
PASS xxxxxxxx
230 User logged in, proceed
SYST
215 Windows_NT
PWD
257 "/" is current path
TYPE I
200 Command okay
PASV
227 Entering Passive Mode (192,168,192,12,39,25)
SIZE /
213 0
MDTM /
213 20090918162141
RETR /
150 File status okay; about to open data connection
226 Closing data connection

Patch in bug #214405 partially fixed this bug, but we can't still list URLs without any directory like ftp://somehost/. I think that it is safe to assume that URL points to directory if mPath is empty.
Attached patch fixSplinter Review
Attachment #407051 - Flags: review?(doug.turner)
michal, any test case for this?
It isn't so easy to write a test for this bug. All existing tests for FTP code use cache for storing and retrieving data. But test for this bug would need a real testing server. Maybe it's time to create it finally (bug #479179)...
Depends on: 479179
An automated FTP test server would be great.  In the meantime, if you've tested this patch on a suitable variety of real FTP servers (including Sysax, obviously), that's probably good enough.
Attachment #407051 - Flags: review?(doug.turner) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/4c7ff4b0f2ba
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Target Milestone: mozilla1.9.3a5 → mozilla1.9.3a6
You need to log in before you can comment on or make changes to this bug.