523127 - Firefox can't list directories on Sysax FTP server

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Michal Novotny [:michal]]

The problem is similar to bug #214405. It is possible to retrieve directory using RETR from Sysax server. Example of the dump:

220- Sysax Multi Server Service (Version 4)
220
USER michal
331 User name okay, need password
PASS xxxxxxxx
230 User logged in, proceed
SYST
215 Windows_NT
PWD
257 "/" is current path
TYPE I
200 Command okay
PASV
227 Entering Passive Mode (192,168,192,12,39,25)
SIZE /
213 0
MDTM /
213 20090918162141
RETR /
150 File status okay; about to open data connection
226 Closing data connection

Patch in bug #214405 partially fixed this bug, but we can't still list URLs without any directory like ftp://somehost/. I think that it is safe to assume that URL points to directory if mPath is empty.

Comment 1

[Michal Novotny [:michal]]

Attachment: fix

Comment 2

[Doug Turner (:dougt)]

michal, any test case for this?

Comment 3

[Michal Novotny [:michal]]

It isn't so easy to write a test for this bug. All existing tests for FTP code use cache for storing and retrieving data. But test for this bug would need a real testing server. Maybe it's time to create it finally (bug #479179)...

Comment 4

[Jason Duell]

An automated FTP test server would be great.  In the meantime, if you've tested this patch on a suitable variety of real FTP servers (including Sysax, obviously), that's probably good enough.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/4c7ff4b0f2ba