523162 - prtypes.h always included in a CROSS_COMPILE build

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[ash_mozilla]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_8; en-us) AppleWebKit/532.3+ (KHTML, like Gecko) Version/4.0.3 Safari/531.9
Build Identifier: 

jscpucfg.cpp always includes prtypes.h in a cross compile build.

Patch coming

Reproducible: Always

Comment 1

[ash_mozilla]

Attachment: Simple patch.

Comment 2

[Jason Orendorff [:jorendorff]]

I don't think we want this exact patch because prtypes.h is what defines IS_BIG_ENDIAN.

Comment 3

[ash_mozilla]

Ahh, this makes a bit more sense. So some form of autoconf test to see if nspr exists for the cross-compile target might be the way to go?

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #3)
> Ahh, this makes a bit more sense. So some form of autoconf test to see if nspr
> exists for the cross-compile target might be the way to go?

No, the problem is that even if you're building with NSPR, jscpucfg is built with the -host- compiler, since it's going to generate a .h file.  So the nspr prtypes.h isn't useful.

Comment 5

[(not currently active) Ted Mielczarek]

bug 694499 removed jscpucfg.