Closed
Bug 523337
Opened 15 years ago
Closed 15 years ago
Output of about:support's "Copy all to clipboard" looks really ugly
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3.7a1
People
(Reporter: reed, Assigned: cbartley)
References
Details
Attachments
(1 file, 2 obsolete files)
2.78 KB,
patch
|
Details | Diff | Splinter Review |
Here's a snippet of what the output of about:support's "Copy all to clipboard" looks like:
----------------------------
Application Basics
Name
Firefox
Version
3.7a1pre
Profile Directory
Open Containing Folder
----------------------------
If we're going to be asking users to paste this on forums, can we at least make it more presentable/readable?
Assignee | ||
Comment 1•15 years ago
|
||
(In reply to comment #0)
> Here's a snippet of what the output of about:support's "Copy all to clipboard"
> looks like:
> ...
Which program did you paste the text into?
Reporter | ||
Comment 2•15 years ago
|
||
(In reply to comment #1)
> Which program did you paste the text into?
I tested both gedit and nano (within gnome-terminal). Same result.
Assignee | ||
Comment 3•15 years ago
|
||
(In reply to comment #2)
> (In reply to comment #1)
> > Which program did you paste the text into?
>
> I tested both gedit and nano (within gnome-terminal). Same result.
Oh, right, it's a Linux bug. I should have noticed that.
Right now I'm just always using CR/LF line-endings since that's necessary for Notepad on Windows. It didn't make any difference on any of the Mac programs that I tested.
I think the solution is to choose the line ending character(s) based on the platform, which is probably what I should have done in the first place.
Note to self: Don't forget about Linux.
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → cbartley
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•15 years ago
|
||
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Which program did you paste the text into?
> >
> > I tested both gedit and nano (within gnome-terminal). Same result.
>
> Oh, right, it's a Linux bug. I should have noticed that.
>
> Right now I'm just always using CR/LF line-endings since that's necessary for
> Notepad on Windows. It didn't make any difference on any of the Mac programs
> that I tested.
>
> I think the solution is to choose the line ending character(s) based on the
> platform, which is probably what I should have done in the first place.
>
> Note to self: Don't forget about Linux.
Also, from https://bugzilla.mozilla.org/show_bug.cgi?id=519286#c14:
(In reply to comment #14)
> (From update of attachment 406112 [details] [diff] [review])
> >+ if (text.length > maxPrefValueLen)
> >+ text = text.substring(0, maxPrefValueLen) + "…";
>
> You want intl.ellipsis here.
Assignee | ||
Comment 5•15 years ago
|
||
* CR/LF pairs are now only used on Windows.
* Now uses the intl.ellipsis pref for the ellipsis character.
* Introduced a gPrefService global and refactored accordingly.
Assignee | ||
Comment 6•15 years ago
|
||
(In reply to comment #5)
> Created an attachment (id=408062) [details]
> smarter cr/lf handling, smarter ellipsis handling, and minor refactoring, v1
>
> * CR/LF pairs are now only used on Windows.
> * Now uses the intl.ellipsis pref for the ellipsis character.
> * Introduced a gPrefService global and refactored accordingly.
Reed:
Can you try this out on Linux and verify that it does, in fact, clean up the pasted text?
Note that it's still not going to be perfect. The goal here was just to make it not suck. The pasted text should look something like:
Application Basics
Name
Firefox
Version
3.7a1pre
Profile Directory
Show in Finder
Installed Plugins
about:plugins
Build Configuration
about:buildconfig
Extensions
Name
Version
Enabled
ID
Firebug
1.4.3b1
true
firebug@software.joehewitt.com
SQLite Manager
0.5.5
true
SQLiteManager@mrinalkant.blogspot.com
Modified Preferences
Name
Value
accessibility.typeaheadfind.flashBar
0
browser.history_expire_days.mirror
180
browser.places.importBookmarksHTML
false
browser.places.importDefaults
false
Comment 7•15 years ago
|
||
Comment on attachment 408062 [details] [diff] [review]
smarter cr/lf handling, smarter ellipsis handling, and minor refactoring, v1
>+ try {
>+ return gPrefService.getComplexValue("intl.ellipsis", Ci.nsIPrefLocalizedString).data;
>+ } catch (e) {
>+ return "\u2026";
>+ }
The try/catch is unnecessary, I think.
Assignee | ||
Comment 8•15 years ago
|
||
Removed the try-catch for the code that reads the intl.ellipsis pref, then just eliminated the getEllipsis() function since it's now overkill.
Attachment #408062 -
Attachment is obsolete: true
Assignee | ||
Updated•15 years ago
|
Attachment #408080 -
Attachment is patch: true
Attachment #408080 -
Attachment mime type: application/octet-stream → text/plain
Assignee | ||
Updated•15 years ago
|
Attachment #408080 -
Flags: review?(gavin.sharp)
Updated•15 years ago
|
Attachment #408080 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 9•15 years ago
|
||
>+const ELLIPSIS = gPrefService.getComplexValue("intl.ellipsis",
>+ Ci.nsIPrefLocalizedString).data;
I removed the trailing space and fixed the indentation before landing this.
http://hg.mozilla.org/mozilla-central/rev/bcff852d17fa
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Assignee | ||
Comment 10•15 years ago
|
||
(In reply to comment #9)
> >+const ELLIPSIS = gPrefService.getComplexValue("intl.ellipsis",
> >+ Ci.nsIPrefLocalizedString).data;
>
> I removed the trailing space and fixed the indentation before landing this.
>
> http://hg.mozilla.org/mozilla-central/rev/bcff852d17fa
Can you attach an as-checked-in patch to the bug?
Comment 11•15 years ago
|
||
Attachment #408080 -
Attachment is obsolete: true
Assignee | ||
Updated•15 years ago
|
Flags: wanted-firefox3.6?
You need to log in
before you can comment on or make changes to this bug.
Description
•