Closed
Bug 523500
Opened 16 years ago
Closed 16 years ago
NJ merge: Move around icache-flushing code
Categories
(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)
Tamarin Graveyard
Baseline JIT (CodegenLIR)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: graydon, Assigned: rreitmai)
References
Details
Attachments
(1 file, 1 obsolete file)
|
11.48 KB,
patch
|
Details | Diff | Splinter Review |
The code in tamarin assumes that all branch-patching is done in the context of an assemble() run, and therefore that it's sufficient to flush the icache at the end of that run.
In tracemonkey, we patch exits incrementally as our trace-trees grow. This means that we need the ability to flush little bits of icache after each nPatchBranch call.
The attached patch implements the solution rick and I came up with. Should apply to TR. I haven't managed a full test cycle (and I don't even have some of your platforms) but I think it should be relatively straightforward.
|
Reporter | |
Comment 1•16 years ago
|
||
just a couple changes since previous version, compiles and passes tests here at least.
Attachment #407435 -
Attachment is obsolete: true
|
Assignee | |
Comment 2•16 years ago
|
||
pushed http://hg.mozilla.org/tamarin-redux/rev/916a3b4e0fe5
note patch correction in NativePPC.h should be 'NIns' not 'Nins'
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•