The default bug view has changed. See this FAQ.

Fix building of SeaMonkey Mac (and possibly part of Windows) on trunk following bug 516213 (Freshen WebGL implementation)

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Build Config
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
seamonkey2.1a1
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
Created attachment 407501 [details] [diff] [review]
The fix
[Checkin: Comment 2]

Bug 516213 means that we now require to link against OpenGL on windows & mac for static builds.

The attached patch will do that for trunk builds, and take account of 1.9.2 just in case we go there (its a copy & paste of what I fixed for Thunderbird minus a 1.9.1 ifdef).

I'll land this once we branch (hence no 1.9.1 ifdef), and if necessary it can be used to check the triggering of builders as it is low risk.
Attachment #407501 - Flags: review?(kairo)

Comment 1

8 years ago
Comment on attachment 407501 [details] [diff] [review]
The fix
[Checkin: Comment 2]

Thanks, Mark, this has been on my TODO for "once I'm out of all this 2.0 final trouble" for some time now, as I'd really like to get trunk nightlies to go green again.
I'm somewhat eager to see it land, but agree that it's probably best to wait for branching, given it comes up tomorrow :)
Attachment #407501 - Flags: review?(kairo) → review+
(Assignee)

Comment 2

8 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/054cff11b1e1
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
Depends on: 516858
Blocks: 470184
Flags: in-testsuite-
Created attachment 407836 [details] [diff] [review]
(Bv1) Don't re-add obsolete 'mac' MOZ_WIDGET_TOOLKIT tests
[Checkin: See comment 5]
Attachment #407836 - Flags: review?(kairo)

Comment 4

8 years ago
Comment on attachment 407836 [details] [diff] [review]
(Bv1) Don't re-add obsolete 'mac' MOZ_WIDGET_TOOLKIT tests
[Checkin: See comment 5]

r=me for the actual code change, but please leave all the empty lines in, it's more readable with them than without them.
Attachment #407836 - Flags: review?(kairo) → review+
Attachment #407501 - Attachment description: The fix → The fix [Checkin: Comment 2]
Attachment #407836 - Attachment description: (Bv1) Don't re-add obsolete 'mac' MOZ_WIDGET_TOOLKIT tests → (Bv1) Don't re-add obsolete 'mac' MOZ_WIDGET_TOOLKIT tests [Checkin: See comment 5]
Comment on attachment 407836 [details] [diff] [review]
(Bv1) Don't re-add obsolete 'mac' MOZ_WIDGET_TOOLKIT tests
[Checkin: See comment 5]


http://hg.mozilla.org/comm-central/rev/53d99e4b5403
Bv1, with comment 4 suggestion(s).
OS: Mac OS X → All
You need to log in before you can comment on or make changes to this bug.