523693 - Inline spell checker should be a module

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[[e-mail]]

Currently each spellchecked textbox (which in a stock build is very few, I only know of two in suite) loads its own copy of inlineSpellCheckUI.js; my suggestion is to convert this file into a module so that it is only loaded once.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Plus adding a stub to toolkit/obsolete until other consumers get fixed.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 407601 [details] [diff] [review]
Proposed patch

>diff --git a/toolkit/content/widgets/textbox.xml b/toolkit/content/widgets/textbox.xml

>+              Components.utils.import("resource://gre/modules/InlineSpellChecker.jsm", this);
>+              this.InlineSpellCheckerUI = new this.InlineSpellChecker(textbox.editor);

Doesn't matter much, but I'd use a non-this scope object here.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> Doesn't matter much, but I'd use a non-this scope object here.

Nevermind this, doesn't really make any sense.

Comment 4

[[e-mail]]

Pushed changeset 1ad687761819 to mozilla-central.

Pushed changeset 9ed3e755663a to mozilla-central, because I suck :-(