523762 - template-before_process hook causes infinite recursion if it throws an error

Status: RESOLVED FIXED

(Bugzilla :: Extensions, defect, P1)

Description

[Max Kanat-Alexander]

Bugzilla::Error uses Template::process to throw errors, so if the template-before_process hook itself throws an error, you get an infinite recursion.

Comment 1

[Max Kanat-Alexander]

Actually, I think this is a more general problem--namely that hooks can recurse infinitely a bit too easily. However, SOMETIMES you might want a hook to recurse, in limited circumstances. I can't think of what they would be, but I assume it could happen.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Okay, here's a fairly elegant solution to the problem. For now I'm limiting it to the template-before_process hook, because we can actually tell pretty well whether we want to allow recursion or not.

Comment 3

[Max Kanat-Alexander]

Attachment: v2

I realized that hook recursion would also be overwriting hook_args, so I've fixed that in this version. (Technically that's a bug that could affect the branches as well, but I haven't heard anybody mention it yet and it's quite a complex fix.)

Comment 4

[Max Kanat-Alexander]

Attachment: v3

I'd forgotten the Bugzilla.pm part of the patch.

Comment 5

[Max Kanat-Alexander]

Attachment: v4

Here we go. This fixes the bitrot and is much simpler than the old patch.

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 415300 [details] [diff] [review]
v4

Looks good and solved the recursion problem in my test cases. r=dkl

Comment 7

[Max Kanat-Alexander]

Checking in Bugzilla/Hook.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Hook.pm,v  <--  Hook.pm
new revision: 1.46; previous revision: 1.45
done
Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v  <--  Template.pm
new revision: 1.122; previous revision: 1.121
done