Closed
Bug 523766
Opened 15 years ago
Closed 15 years ago
NJ merge: move jump tables to allocator
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: graydon, Assigned: graydon)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
3.73 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
The current jump-table code allocates its table in code pages via underrunProtect. This causes the maximum underrunProtect value to be set far too high in the i386 backend, which wastes space in the codeAlloc, and is also a little messy and potentially unsafe. Adobe doesn't want to take this hunk into nanojit and I'm inclined to agree. The following patch moves the jump tables (which are just data) into the dataAlloc. In theory they could go in the traceAlloc but I think they're probably small and rare, and in any case we're not presently threading the traceAlloc through to the assembler; perhaps we should? Passes trace-tests.
Attachment #407679 -
Flags: review?(dmandelin)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 407679 [details] [diff] [review] house cleaning Stealing. Very nice cleanup.
Attachment #407679 -
Flags: review?(dmandelin) → review+
|
Assignee | |
Comment 2•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/a8810e7752da
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a8810e7752da
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•