Closed Bug 523809 Opened 10 years ago Closed 10 years ago

crash while moving messages [@nsMsgDBView::GetThreadRootIndex(nsIMsgDBHdr*) ]


(MailNews Core :: Backend, defect, critical)

1.9.1 Branch
Windows XP
Not set


(Not tracked)

Thunderbird 3.0rc1


(Reporter: wsmwk, Assigned: rkent)


(Keywords: crash, fixed-seamonkey2.0.1)

Crash Data


(1 file, 1 obsolete file)

crash while moving messages [@nsMsgDBView::GetThreadRootIndex(nsIMsgDBHdr*) ]
#44 crash for 3.0b4

I don't have clear set of steps. I was in the midst of moving messages by drag and drop, ctrl+shift+M and also via context menu. A couple new subfolders was created minutes before, in local account.

my crash comment "One is gloda search stuck on "Searching"" documents that one tab (left running overnight) is a stuck gloda search. That search never returned results. No loop afaict. Might file separate bug on that.

bsmedberg also crashed

0	thunderbird.exe	nsMsgDBView::GetThreadRootIndex	 mailnews/base/src/nsMsgDBView.cpp:5337
1	thunderbird.exe	nsMsgSearchDBView::AddHdrFromFolder	mailnews/base/src/nsMsgSearchDBView.cpp:467
2	thunderbird.exe	nsMsgSearchDBView::InsertHdrFromFolder	mailnews/base/src/nsMsgSearchDBView.cpp:667
3	thunderbird.exe	nsMsgSearchDBView::OnSearchHit	mailnews/base/src/nsMsgSearchDBView.cpp:699
4	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
5	thunderbird.exe	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2297
6	thunderbird.exe	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1590
forgot to say, this is not a new crash. appears in both 3.0b1 and b2.  My crash is the only one ever reported as a nightly.
Assignee: nobody → kent
Attached patch Rev a: check for null header (obsolete) — Splinter Review
Attachment #407780 - Flags: superreview?(bienvenu)
Attachment #407780 - Flags: review?(bienvenu)
Comment on attachment 407780 [details] [diff] [review]
Rev a: check for null header

looks reasonable, thx. A warning or even an assertion in ::GetThreadRootIndex might be nice, since that should be highly unexpected.
Attachment #407780 - Flags: superreview?(bienvenu)
Attachment #407780 - Flags: superreview+
Attachment #407780 - Flags: review?(bienvenu)
Attachment #407780 - Flags: review+
Added the requested warning, now need approval for TB3 (for checkin once tree reopens).
Attachment #407780 - Attachment is obsolete: true
Attachment #407806 - Flags: approval-thunderbird3?
Whiteboard: [needs a-tb3+]
Attachment #407806 - Flags: approval-thunderbird3? → approval-thunderbird3+
Comment on attachment 407806 [details] [diff] [review]
Rev b: add NS_WARNING

Please check into trunk and branch.
Comment on attachment 407806 [details] [diff] [review]
Rev b: add NS_WARNING

Checked into trunk
Comment on attachment 407806 [details] [diff] [review]
Rev b: add NS_WARNING

Checked into branch as
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
Whiteboard: [needs a-tb3+]
Crash Signature: [@nsMsgDBView::GetThreadRootIndex(nsIMsgDBHdr*) ]
You need to log in before you can comment on or make changes to this bug.