Open Bug 523941 Opened 13 years ago Updated 3 years ago

dom netOffline shouldn't mention menus

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

ASSIGNED

People

(Reporter: timeless, Assigned: timeless)

References

()

Details

Attachments

(1 file)

Mozilla Cross-Reference mozilla-central
Searching these files for this text.
netOffline

/dom/locales/en-US/chrome/appstrings.properties (View Hg log or Hg annotations)

    * line 49 -- netOffline=This document cannot be displayed while offline. To go online, uncheck Work Offline from the File menu.

/browser/locales/en-US/chrome/overrides/appstrings.properties (View Hg log or Hg annotations)

    * line 50 -- netOffline=Firefox is currently in offline mode and can't browse the Web.

Found 2 matching lines in 2 files

This page was automatically generated by MXR.

My application doesn't have a file menu! Why is gecko demanding that i include one?

And yes, i could provide my own override, but then i'd have to translate that message.

Csn we please switch to: 
%appShortname% is currently in offline mode and can't browse the Web.
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #407876 - Flags: review?(bzbarsky)
Comment on attachment 407876 [details] [diff] [review]
patch

Please condition this on a boolean like addHostPort so we don't have to hit this for every error page?
Attachment #407876 - Flags: review?(bzbarsky) → review-
Comment on attachment 407876 [details] [diff] [review]
patch

I was kinda hoping that we could add it globally
so any error message from net error could use it
to make any specific error message personalizable
Attachment #407876 - Flags: review- → review?(bzbarsky)
Comment on attachment 407876 [details] [diff] [review]
patch

>+externalProtocolUnknown=<Unknown>

Nix this, and r=bzbarsky
Attachment #407876 - Flags: review?(bzbarsky) → review+
Comment on attachment 407876 [details] [diff] [review]
patch

Er, and the key name needs to be changed too.
Attachment #407876 - Flags: review+ → review-
(In reply to comment #0)
> Csn we please switch to: 
> %appShortname% is currently in offline mode and can't browse the Web.

Please read bug 302309 comment 23.

Also, not all consumers of appstrings.properties are web browsers, so it's important to keep the errors as generic as possible in the Core file (no app names, no protocols, and, I agree, no menus) and let those who want specifics override it to fit their apps.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.