524003 - Messages originating from the connected user not sent from ChatZilla are not marked as from the user

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[test.email.things]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 3.5.30729)
Build Identifier: 0.9.85

Irssi-proxy allows for one connection to IRC on a remote server, and several other clients can connect to that connection and behave as if they were that connection. So, for example, you can connect to IRC as Fred on your server, then send and receive messages as Fred from all your home computers.

This works fine for other IRC clients I've tried - Colloquy, Irssi, Bitchx, etc. - and in each case if I write something on one client it appears on all the others as if I had just said it (the line, name, etc. is formatted as it would be had I sat down at that client to send the text).

On Chatzilla, it instead is formatted as a message written by someone with the same name - so instead of the name being in black (expected behaviour), it's a hyperlink (in the same way as other people are displayed). Worst still, Chatzilla then Notifies me that someone has said my name (picking up on the <name> being identical to my name). 

Reproducible: Always

Steps to Reproduce:
1.Install irssi
2.Load and set up the proxy module (there are many sets of instructions on Google)
3.Connect to the proxy using Chatzilla, and again using a different client (eg. irssi)
4.Type something into the other client, and see how it displays under Chatzilla
Actual Results:  
Text appears in the same style as when other people speak, my name is hyperlinked, and Chatzilla Notifies for that line.

Expected Results:  
Treat the text as it would had I typed it into Chatzilla - ie. not Notify me, and keep the name without a hyperlink

Comment 1

[David Vo [:auscompgeek]]

I have also seen this behavior with ChatZilla connected to a ZNC. You could also reproduce this by faking a message from the server in the normal PRIVMSG format originating from yourself.

Comment 2

[James Ross]

Attachment: Accept CIRCChanUser objects as 'me' when canonicalName matches

So what happens is that we get a CIRCChanUser object in the display code and compare it to the CIRCUser object for 'me'. The two obviously don't == so we treat the messages as foreign. This patch allows for any object with a canonicalName that == me.canonicalName to be treated as 'me'.

Comment 3

[James Ross]

http://hg.mozilla.org/chatzilla/rev/5a0e370d6cf4