Last Comment Bug 524010 - Maemo repackages of individual locales should be done in a meaningful location
: Maemo repackages of individual locales should be done in a meaningful location
Status: RESOLVED FIXED
:
Product: Release Engineering
Classification: Other
Component: Other (show other bugs)
: other
: All All
: P2 normal (vote)
: ---
Assigned To: Armen Zambrano [:armenzg] (EDT/UTC-4)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-22 18:30 PDT by Armen Zambrano [:armenzg] (EDT/UTC-4)
Modified: 2013-08-12 21:54 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Rename mobile l10n workdirs (8.82 KB, patch)
2009-10-26 20:01 PDT, Chris Cooper [:coop]
armenzg: review+
Details | Diff | Splinter Review
Rename mobile l10n workdirs, production patch (8.79 KB, patch)
2009-10-27 13:59 PDT, Chris Cooper [:coop]
armenzg: review+
Details | Diff | Splinter Review
Rename mobile l10n workdirs, corrected for bitrot (17.81 KB, patch)
2009-10-29 09:03 PDT, Chris Cooper [:coop]
coop: review+
coop: checked‑in+
Details | Diff | Splinter Review

Description Armen Zambrano [:armenzg] (EDT/UTC-4) 2009-10-22 18:30:19 PDT
In bug 519684 I am fixing where the Maemo builds are happening under scratchbox to avoid a collision that was happening for the "l10n" directory since it was shared among different branches.

In this bug I am just asking to check out things in a more meaningful way even though there is not collision.

The changes required would be in mobile_config.py and they would be like: 
  ...['linux-gnueabi-arm']['base_builddir'] = 'maemo-trunk'
- ...['linux-gnueabi-arm']['base_l10n_workdir'] = '%s/l10n' % SBOX_HOME
+ ...['linux-gnueabi-arm']['base_l10n_workdir'] = '%s/build/maemo-trunk-l10n' % SBOX_HOME
or something like that where the directory structure would be something like this:

build/
  maemo-trunk
  maemo-trunk-l10n
  maemo-1.9.2
  maemo-1.9.2-l10n
Comment 1 John Ford [:jhford] CET/CEST Berlin Time 2009-10-23 16:39:50 PDT
That shouldn't be a huge change, but we will need to make sure that those locations aren't hardcoded in other parts of the code.
Comment 2 Chris Cooper [:coop] 2009-10-25 10:17:36 PDT
Armen asked me to take this.

John (Ford): would there be anything in the mobile or l10n repos that would reference this directly, or will I be fine checking buildbot-configs and buildbotcustom?
Comment 3 Chris Cooper [:coop] 2009-10-26 19:59:54 PDT
(In reply to comment #0)
> In bug 519684 I am fixing where the Maemo builds are happening under scratchbox
> to avoid a collision that was happening for the "l10n" directory since it was
> shared among different branches.
> 
> In this bug I am just asking to check out things in a more meaningful way even
> though there is not collision.
> 
> The changes required would be in mobile_config.py and they would be like: 
>   ...['linux-gnueabi-arm']['base_builddir'] = 'maemo-trunk'
> - ...['linux-gnueabi-arm']['base_l10n_workdir'] = '%s/l10n' % SBOX_HOME
> + ...['linux-gnueabi-arm']['base_l10n_workdir'] = '%s/build/maemo-trunk-l10n' %
> SBOX_HOME
> or something like that where the directory structure would be something like
> this:
> 
> build/
>   maemo-trunk
>   maemo-trunk-l10n
>   maemo-1.9.2
>   maemo-1.9.2-l10n
Comment 4 Chris Cooper [:coop] 2009-10-26 20:01:16 PDT
Created attachment 408545 [details] [diff] [review]
Rename mobile l10n workdirs

This is running on staging-master2 right now.
Comment 5 Chris Cooper [:coop] 2009-10-27 13:59:43 PDT
Created attachment 408677 [details] [diff] [review]
Rename mobile l10n workdirs, production patch
Comment 6 Armen Zambrano [:armenzg] (EDT/UTC-4) 2009-10-28 10:18:51 PDT
Folder "l10n" under scratchbox will not be in used anymore and will require to manually remove it. This can be done with cssh (I have it set up if you want me to do it)
Comment 7 Chris Cooper [:coop] 2009-10-29 09:03:56 PDT
Created attachment 409096 [details] [diff] [review]
Rename mobile l10n workdirs, corrected for bitrot

Carrying forward previous review, just fixing the bitrot.
Comment 8 Chris Cooper [:coop] 2009-11-11 13:45:24 PST
Comment on attachment 409096 [details] [diff] [review]
Rename mobile l10n workdirs, corrected for bitrot

http://hg.mozilla.org/build/buildbot-configs/rev/bf93f21951fe
Comment 9 Armen Zambrano [:armenzg] (EDT/UTC-4) 2009-11-11 14:06:36 PST
I will jump and clean the slaves before the end of today since I have things set up to access all slaves.

I will start doing it no sooner than 40 minutes (repackages take less than 5 minutes) after the reconfiguration of the masters.
Comment 10 Chris Cooper [:coop] 2009-11-11 14:10:05 PST
production-master* have been reconfig-ed with this change.

Re-assigning to Armen for the slave cleanup.
Comment 11 Armen Zambrano [:armenzg] (EDT/UTC-4) 2009-11-11 19:35:55 PST
I removed SBOX_HOME/l10n from all linux slaves 01 to 49.
I will check again later today to see if everything is OK.
Comment 12 Nick Thomas [:nthomas] 2009-11-11 19:39:07 PST
But not slave 50 ?
Comment 13 Armen Zambrano [:armenzg] (EDT/UTC-4) 2009-11-12 10:52:44 PST
(In reply to comment #12)
> But not slave 50 ?
My bad. 50 was done as well.

I went around yesterday and I put the removing processes in the background to be able to don't have to wait for each batch of slaves. When I checked this morning some of it had delete what I wanted and some not.

There is no internet where I am going so I will have to finish this on Monday.
If anyone takes this, all slaves should have a SBOX/l10n.delete folder instead of SBOX/l10n since I moved them before deleting them.
Comment 14 Aki Sasaki [:aki] 2009-11-12 23:26:13 PST
I have nuked /scratchbox/users/cltbld/home/cltbld/build, l10n (if it exists), and l10n.delete on moz2-linux-slave01 through 50... I had to go in there anyway to clobber the Maemo depend build dirs (bug 489410).

This bug looks done; please reopen if I'm resolving prematurely.
Comment 15 Armen Zambrano [:armenzg] (EDT/UTC-4) 2009-11-16 07:54:39 PST
Aki thanks tons!

Note You need to log in before you can comment on or make changes to this bug.