524172 - Personas leaves a horizontal toolbar with Multirow Bookmarks toolbar extension

Status: VERIFIED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Tony Chung [:tchung]]

Attachment: Slider screenshot

When multirow bookmarks toolbar is installed, adding a lightweight personas theme will create an extra horizontal slider below the bookmarks toolbar.   

See screenshot

Repro:
1) install trunk or 3.6beta1: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1) Gecko/20091019 Firefox/3.6b1
2) add the multirow bookmarks Toolbar v4.0 extension (see URL)
3) go to getpersonas.com, and add a persona lightweight theme
4) Verify a horizontal page slider gets added below the bookmarks toolbar

Expected:
- No slider

Actual: 
- Slider

Comment 1

[Jose E. Bolanos]

This issue is resolved by changing the following CSS style rule (added by
Multirow Bookmarks):

#personal-bookmarks[multi] #bookmarksBarContent

From:
overflow-y: auto;
To:
overflow-y: visible;

This change does not affect the functionality of the Multirow Bookmarks add-on.

Should we add a rule of our own that nullifies this rule? If so, this should be
changed in both Firefox and the Personas add-on, since it affects the browser
even when the add-on is not installed.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

It sounds like this is something that the Multirow Bookmarks add-on should fix in its own code, so that it is compatible with the new version of Firefox (and also with Personas).

Comment 3

[Jose E. Bolanos]

(In reply to comment #2)
> It sounds like this is something that the Multirow Bookmarks add-on should fix
> in its own code, so that it is compatible with the new version of Firefox (and
> also with Personas).

I agree. It would be best to approach the Multirow Bookmarks add-on author(s) with this proposed solution (which is trivial) and see what they think maybe?

Comment 4

[Johnathan Nightingale [:johnath]]

Not that you need my vote to continue, but Suneel pointed my attention to this bug, and I agree with Myk - this is something we should contact the author about fixing in their add on.

Comment 5

[Suneel]

Fligtar, would it be possible for us to reach out to the Multirow Bookmarks add-on author about potentially making this fix on their end?

Comment 6

[Suneel]

This requires no additional changes on the Personas side. Suneel to follow up with Fligtar to reach out to add-on author.

Comment 7

[Tony Chung [:tchung]]

i dont think you should wontix it just quite yet. We should continue to track the progress of the fix here; even if its an external "Fixed by author".   This way someone can double confirm it when it really is fixed.

Comment 8

[Justin Scott [:fligtar]]

Emailed the author about this bug.

Comment 9

[Alice0775 White]

I think that this issue is Bug 517526.
it's LAYOUT core bug.

Comment 10

[Alice0775 White]

Version 4.2 had been shipped which is 
workaround of Bug 517526 with the Light Weight Theme.

Comment 11

[Suneel]

resolving this bug based on the comment above.

Tomcat, are you able to verify?

Comment 12

[Tony Chung [:tchung]]

Verified fix with multirow bookmarks 4.3, and personas 1.5.   Thanks Alice!